Make WordPress Core


Ignore:
Timestamp:
07/22/2022 01:58:46 PM (2 years ago)
Author:
spacedmonkey
Message:

REST API: Avoid unnecessarily preparing item links.

Do not call the prepare_links methods in core REST API controllers, unless the _links or _embedded fields are requested. There is no need to prepare links if they are never returned in the response. This saves resources, as many calls to prepare_links methods perform database queries.

Props Spacedmonkey, timothyblynjacobs, rachelbaker, desrosj, dlh, hellofromTonya.
Fixes #52992.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-menus-controller.php

    r52079 r53760  
    135135
    136136        $response = rest_ensure_response( $data );
    137         $response->add_links( $this->prepare_links( $term ) );
     137
     138        if ( rest_is_field_included( '_links', $fields ) || rest_is_field_included( '_embedded', $fields ) ) {
     139            $response->add_links( $this->prepare_links( $term ) );
     140        }
    138141
    139142        /** This action is documented in wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php */
Note: See TracChangeset for help on using the changeset viewer.