Changeset 53760 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-plugins-controller.php

Timestamp:

07/22/2022 01:58:46 PM (3 years ago)

Author:

spacedmonkey

Message:

REST API: Avoid unnecessarily preparing item links.

Do not call the prepare_links methods in core REST API controllers, unless the _links or _embedded fields are requested. There is no need to prepare links if they are never returned in the response. This saves resources, as many calls to prepare_links methods perform database queries.

Props Spacedmonkey, timothyblynjacobs, rachelbaker, desrosj, dlh, hellofromTonya.
Fixes #52992.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-plugins-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-plugins-controller.php

@@ -577 +577 @@
      */
     public function prepare_item_for_response( $item, $request ) {
+        $fields = $this->get_fields_for_response( $request );
+
         $item   = _get_plugin_data_markup_translate( $item['_file'], $item, false );
         $marked = _get_plugin_data_markup_translate( $item['_file'], $item, true );
@@ -601 +603 @@
 
         $response = new WP_REST_Response( $data );
-        $response->add_links( $this->prepare_links( $item ) );
+
+        if ( rest_is_field_included( '_links', $fields ) || rest_is_field_included( '_embedded', $fields ) ) {
+            $response->add_links( $this->prepare_links( $item ) );
+        }
 
         /**