Changeset 53760 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-search-controller.php

Timestamp:

07/22/2022 01:58:46 PM (3 years ago)

Author:

spacedmonkey

Message:

REST API: Avoid unnecessarily preparing item links.

Do not call the prepare_links methods in core REST API controllers, unless the _links or _embedded fields are requested. There is no need to prepare links if they are never returned in the response. This saves resources, as many calls to prepare_links methods perform database queries.

Props Spacedmonkey, timothyblynjacobs, rachelbaker, desrosj, dlh, hellofromTonya.
Fixes #52992.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-search-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-search-controller.php

@@ -211 +211 @@
         $response = rest_ensure_response( $data );
 
-        $links               = $handler->prepare_item_links( $item_id );
-        $links['collection'] = array(
-            'href' => rest_url( sprintf( '%s/%s', $this->namespace, $this->rest_base ) ),
-        );
-        $response->add_links( $links );
+        if ( rest_is_field_included( '_links', $fields ) || rest_is_field_included( '_embedded', $fields ) ) {
+            $links               = $handler->prepare_item_links( $item_id );
+            $links['collection'] = array(
+                'href' => rest_url( sprintf( '%s/%s', $this->namespace, $this->rest_base ) ),
+            );
+            $response->add_links( $links );
+        }
 
         return $response;