Make WordPress Core


Ignore:
Timestamp:
07/22/2022 01:58:46 PM (3 years ago)
Author:
spacedmonkey
Message:

REST API: Avoid unnecessarily preparing item links.

Do not call the prepare_links methods in core REST API controllers, unless the _links or _embedded fields are requested. There is no need to prepare links if they are never returned in the response. This saves resources, as many calls to prepare_links methods perform database queries.

Props Spacedmonkey, timothyblynjacobs, rachelbaker, desrosj, dlh, hellofromTonya.
Fixes #52992.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

    r52068 r53760  
    860860        $response = rest_ensure_response( $data );
    861861
    862         $response->add_links( $this->prepare_links( $item ) );
     862        if ( rest_is_field_included( '_links', $fields ) || rest_is_field_included( '_embedded', $fields ) ) {
     863            $response->add_links( $this->prepare_links( $item ) );
     864        }
    863865
    864866        /**
Note: See TracChangeset for help on using the changeset viewer.