Changeset 53771

Timestamp:

07/24/2022 01:24:44 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Check if the post type exists in wp_insert_post().

This avoids an Attempt to read property "cap" on null PHP warning when checking an unregistered post type's publish_posts capability to disallow contributors setting the post slug for pending posts.

Follow-up to [9055], [42380].

Props Chouby, mukesh27, rafiahmedd, SergeyBiryukov.
Fixes #55877.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -4160 +4160 @@
          * For new posts check the primitive capability, for updates check the meta capability.
          */
-        $post_type_object = get_post_type_object( $post_type );
-
-        if ( ! $update && 'pending' === $post_status && ! current_user_can( $post_type_object->cap->publish_posts ) ) {
-                $post_name = '';
-        } elseif ( $update && 'pending' === $post_status && ! current_user_can( 'publish_post', $post_ID ) ) {
-                $post_name = '';
+        if ( 'pending' === $post_status ) {
+                $post_type_object = get_post_type_object( $post_type );
+
+                if ( ! $update && $post_type_object && ! current_user_can( $post_type_object->cap->publish_posts ) ) {
+                        $post_name = '';
+                } elseif ( $update && ! current_user_can( 'publish_post', $post_ID ) ) {
+                        $post_name = '';
+                }
         }
 

trunk/tests/phpunit/tests/post.php

@@ -503 +503 @@
 
         /**
+         * @ticket 55877
+         * @covers ::wp_insert_post
+         */
+        public function test_wp_insert_post_should_not_trigger_warning_for_pending_posts_with_unknown_cpt() {
+                $post_id = wp_insert_post(
+                        array(
+                                'post_title'  => 'title',
+                                'post_type'   => 'unknown',
+                                'post_status' => 'pending',
+                        )
+                );
+
+                $this->assertIsNumeric( $post_id );
+                $this->assertGreaterThan( 0, $post_id );
+        }
+
+        /**
          * @ticket 20451
          */