Changeset 53778 for trunk/tests/phpunit/tests/post/revisions.php

Timestamp:

07/25/2022 07:18:41 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Revisions: Rename the function for retrieving the latest revision ID and total count.

The new name is wp_get_latest_revision_id_and_total_count().

This aims to reduce ambiguity about what exactly is the "first" or "last" revision, and bring more consistency with similar wording elsewhere in core, e.g. latest posts, latest comments, etc.

Follow-up to [53759], [53769].

Props peterwilsoncc.
See #55857.

File:

• trunk/tests/phpunit/tests/post/revisions.php (modified) (4 diffs)

trunk/tests/phpunit/tests/post/revisions.php

@@ -657 +657 @@
 
     /**
-     * Tests that wp_get_last_revision_id_and_total_count() returns the last revision ID and total count.
-     *
+     * Tests that wp_get_latest_revision_id_and_total_count() returns the latest revision ID and total count.
+     *
+     * @covers ::wp_get_latest_revision_id_and_total_count
      * @ticket 55857
      * @dataProvider data_wp_get_post_revisions_url
      */
-    public function test_wp_get_last_revision_id_and_total_count( $revisions ) {
+    public function test_wp_get_latest_revision_id_and_total_count( $revisions ) {
         $post_id = self::factory()->post->create();
         for ( $i = 0; $i < $revisions; ++$i ) {
@@ -673 +674 @@
         }
 
-        $post_revisions     = wp_get_post_revisions( $post_id );
-        $last_post_revision = current( $post_revisions );
-        $revision           = wp_get_last_revision_id_and_total_count( $post_id );
+        $post_revisions       = wp_get_post_revisions( $post_id );
+        $latest_post_revision = current( $post_revisions );
+        $revision             = wp_get_latest_revision_id_and_total_count( $post_id );
 
         $this->assertSame(
-            $last_post_revision->ID,
+            $latest_post_revision->ID,
             $revision['revision'],
-            'The last revision ID does not match.'
+            'The latest revision ID does not match.'
         );
 
@@ -691 +692 @@
 
     /**
-     * Tests that wp_get_last_revision_id_and_total_count() returns a WP_Error when no revisions exist.
-     *
+     * Tests that wp_get_latest_revision_id_and_total_count() returns a WP_Error when no revisions exist.
+     *
+     * @covers ::wp_get_latest_revision_id_and_total_count
      * @ticket 55857
      */
-    public function test_wp_get_last_revision_id_and_total_count_no_revisions() {
-        $revision = wp_get_last_revision_id_and_total_count( null );
+    public function test_wp_get_latest_revision_id_and_total_count_no_revisions() {
+        $revision = wp_get_latest_revision_id_and_total_count( null );
 
         $this->assertWPError( $revision, 'Invalid post, no revisions should exist.' );
@@ -703 +705 @@
         add_filter( 'wp_revisions_to_keep', '__return_zero' );
         $post_id  = self::factory()->post->create();
-        $revision = wp_get_last_revision_id_and_total_count( $post_id );
+        $revision = wp_get_latest_revision_id_and_total_count( $post_id );
 
         $this->assertWPError( $revision, 'Revisions should not be enabled.' );