Changeset 53779

Timestamp:

07/25/2022 07:28:29 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Revisions: Update the "last revision" wording to "latest revision" in various files.

This aims to reduce ambiguity about what exactly is the "first" or "last" revision, and bring more consistency with similar wording elsewhere in core, e.g. latest posts, latest comments, etc.

This affects:

• wp_save_post_revision()
• wp_prepare_revisions_for_js()
• WP_Customize_Manager::filter_revision_post_has_changed()

Follow-up to [53759], [53769], [53778].

Props peterwilsoncc.
Fixes #55857.

Location:

trunk/src

Files:

• wp-admin/includes/revision.php (modified) (1 diff)
• wp-includes/class-wp-customize-manager.php (modified) (1 diff)
• wp-includes/revision.php (modified) (4 diffs)

trunk/src/wp-admin/includes/revision.php

@@ -301 +301 @@
 
         /*
-         * If a post has been saved since the last revision (no revisioned fields
+         * If a post has been saved since the latest revision (no revisioned fields
          * were changed), we may not have a "current" revision. Mark the latest
          * revision as "current".

trunk/src/wp-includes/class-wp-customize-manager.php

@@ -3428 +3428 @@
          *
          * @param bool    $post_has_changed Whether the post has changed.
-         * @param WP_Post $last_revision    The last revision post object.
+         * @param WP_Post $latest_revision  The latest revision post object.
          * @param WP_Post $post             The post object.
          * @return bool Whether a revision should be made.
          */
-        public function _filter_revision_post_has_changed( $post_has_changed, $last_revision, $post ) {
-                unset( $last_revision );
+        public function _filter_revision_post_has_changed( $post_has_changed, $latest_revision, $post ) {
+                unset( $latest_revision );
                 if ( 'customize_changeset' === $post->post_type ) {
                         $post_has_changed = $this->store_changeset_revision;

trunk/src/wp-includes/revision.php

@@ -137 +137 @@
         $revisions = wp_get_post_revisions( $post_id );
         if ( $revisions ) {
-                // Grab the last revision, but not an autosave.
+                // Grab the latest revision, but not an autosave.
                 foreach ( $revisions as $revision ) {
                         if ( false !== strpos( $revision->post_name, "{$revision->post_parent}-revision" ) ) {
-                                $last_revision = $revision;
+                                $latest_revision = $revision;
                                 break;
                         }
@@ -146 +146 @@
 
                 /**
-                 * Filters whether the post has changed since the last revision.
+                 * Filters whether the post has changed since the latest revision.
                  *
                  * By default a revision is saved only if one of the revisioned fields has changed.
@@ -155 +155 @@
                  * @param bool    $check_for_changes Whether to check for changes before saving a new revision.
                  *                                   Default true.
-                 * @param WP_Post $last_revision     The last revision post object.
+                 * @param WP_Post $latest_revision   The latest revision post object.
                  * @param WP_Post $post              The post object.
                  */
-                if ( isset( $last_revision ) && apply_filters( 'wp_save_post_revision_check_for_changes', true, $last_revision, $post ) ) {
+                if ( isset( $latest_revision ) && apply_filters( 'wp_save_post_revision_check_for_changes', true, $latest_revision, $post ) ) {
                         $post_has_changed = false;
 
                         foreach ( array_keys( _wp_post_revision_fields( $post ) ) as $field ) {
-                                if ( normalize_whitespace( $post->$field ) !== normalize_whitespace( $last_revision->$field ) ) {
+                                if ( normalize_whitespace( $post->$field ) !== normalize_whitespace( $latest_revision->$field ) ) {
                                         $post_has_changed = true;
                                         break;
@@ -177 +177 @@
                          *
                          * @param bool    $post_has_changed Whether the post has changed.
-                         * @param WP_Post $last_revision    The last revision post object.
+                         * @param WP_Post $latest_revision  The latest revision post object.
                          * @param WP_Post $post             The post object.
                          */
-                        $post_has_changed = (bool) apply_filters( 'wp_save_post_revision_post_has_changed', $post_has_changed, $last_revision, $post );
+                        $post_has_changed = (bool) apply_filters( 'wp_save_post_revision_post_has_changed', $post_has_changed, $latest_revision, $post );
 
                         // Don't save revision if post unchanged.