Context Navigation

← Previous Change
Next Change →

cron.php

Timestamp:

07/29/2022 03:32:58 AM (4 years ago)

Author:

peterwilsoncc

Message:

Cron API: Modify _get_cron_array() to always return an array.

Change the return type of _get_cron_array() to an empty array if the cron option is either missing or of an
unexpected type.

This change ensures the return value for no registered events is consistently an empty array. Previously the return
value could be either an empty array or false.

Props thakkarhardik, jrf, costdev.
Fixes #53940.

File:

: 1 edited

trunk/src/wp-includes/cron.php (modified) (4 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-includes/cron.php

-              r52236
+              r53791
          */
         $crons = _get_cron_array();
-        if ( ! is_array( $crons ) ) {
-                $crons = array();
+        }
         $key       = md5( serialize( $event->args ) );
 …
         $crons = _get_cron_array();
-        if ( ! is_array( $crons ) ) {
-                $crons = array();
+        }
         $crons[ $event->timestamp ][ $event->hook ][ $key ] = array(
 …
         $crons = _get_cron_array();
-        if ( ! is_array( $crons ) ) {
-                return array();
+        }
         $gmt_time = microtime( true );
 …
+ *
  * @since 2.1.0
+ * @since 6.1.0 Return type modified to consistenty return an array.
  * @access private
+ *
  * @return array[]|false Array of cron info arrays on success, false on failure.
+ * @return array[] Array of cron events.
  */
 function _get_cron_array() {
         $cron = get_option( 'cron' );
         if ( ! is_array( $cron ) ) {
                 return false;
+                return array();
+        }

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 53791 for trunk/src/wp-includes/cron.php

Legend:

trunk/src/wp-includes/cron.php

Download in other formats: