Changeset 53791 for trunk/tests/phpunit/tests/cron.php

Timestamp:

07/29/2022 03:32:58 AM (3 years ago)

Author:

peterwilsoncc

Message:

Cron API: Modify _get_cron_array() to always return an array.

Change the return type of _get_cron_array() to an empty array if the cron option is either missing or of an
unexpected type.

This change ensures the return value for no registered events is consistently an empty array. Previously the return
value could be either an empty array or false.

Props thakkarhardik, jrf, costdev.
Fixes #53940.

File:

• trunk/tests/phpunit/tests/cron.php (modified) (2 diffs)

trunk/tests/phpunit/tests/cron.php

@@ -131 +131 @@
 
         // Verify that the cause of the error is in place.
-        $this->assertFalse( _get_cron_array(), '_get_cron_array() does not return false' );
+        $this->assertIsArray( _get_cron_array(), '_get_cron_array() does not return an array.' );
+        $this->assertEmpty( _get_cron_array(), '_get_cron_array() does not return an empty array.' );
 
         $hook      = __FUNCTION__;
@@ -152 +153 @@
 
         // Verify that the cause of the error is in place.
-        $this->assertFalse( _get_cron_array(), '_get_cron_array() does not return false' );
+        $this->assertIsArray( _get_cron_array(), '_get_cron_array() does not return an array.' );
+        $this->assertEmpty( _get_cron_array(), '_get_cron_array() does not return an empty array.' );
 
         $hook      = __FUNCTION__;