Changeset 53796 for trunk/src/wp-includes/comment-template.php

Timestamp:

07/29/2022 05:04:25 PM (3 years ago)

Author:

audrasjb

Message:

Comments: Improve accessibility of the "Logged in as" link in comment form.

This changeset ensures the "Logged in as" link conveys the information about its purpose ("Edit your profile") while the information "Logged in as Jane Doe" is only a simple text.

Props juliemoynat, SergeyBiryukov, joedolson, audrasjb, lopo.
Fixes #55718.

File:

• trunk/src/wp-includes/comment-template.php (modified) (3 diffs)

trunk/src/wp-includes/comment-template.php

@@ -2289 +2289 @@
  *     @type string $comment_field        The comment textarea field HTML.
  *     @type string $must_log_in          HTML element for a 'must be logged in to comment' message.
- *     @type string $logged_in_as         HTML element for a 'logged in as [user]' message.
+ *     @type string $logged_in_as         The HTML for the 'logged in as [user]' message, the Edit profile link,
+ *                                        and the Log out link.
  *     @type string $comment_notes_before HTML element for a message displayed before the comment fields
  *                                        if the user is not logged in.
@@ -2458 +2459 @@
             '<p class="logged-in-as">%s%s</p>',
             sprintf(
-                /* translators: 1: Edit user link, 2: Accessibility text, 3: User name, 4: Logout URL. */
-                __( '<a href="%1$s" aria-label="%2$s">Logged in as %3$s</a>. <a href="%4$s">Log out?</a>' ),
+                /* translators: 1: User name, 2: Edit user link, 3: Logout URL. */
+                __( 'Logged in as %1$s. <a href="%2$s">Edit your profile</a>. <a href="%3$s">Log out?</a>' ),
+                $user_identity,
                 get_edit_user_link(),
-                /* translators: %s: User name. */
-                esc_attr( sprintf( __( 'Logged in as %s. Edit your profile.' ), $user_identity ) ),
-                $user_identity,
                 /** This filter is documented in wp-includes/link-template.php */
                 wp_logout_url( apply_filters( 'the_permalink', get_permalink( $post_id ), $post_id ) )
@@ -2579 +2578 @@
                  * @since 3.0.0
                  *
-                 * @param string $args_logged_in The logged-in-as HTML-formatted message.
+                 * @param string $args_logged_in The HTML for the 'logged in as [user]' message,
+                 *                               the Edit profile link, and the Log out link.
                  * @param array  $commenter      An array containing the comment author's
                  *                               username, email, and URL.