Changeset 53804 for trunk/tests/phpunit/tests/hooks/hasFilter.php

Timestamp:

07/31/2022 03:03:46 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Update the terminology used for action or filter names in hook tests.

This replaces the $tag variables with $hook_name, to match the core function signatures.

Follow-up to [24/tests], [62/tests], [866/tests], [1294/tests], [38571], [50807].

See #55652.

File:

• trunk/tests/phpunit/tests/hooks/hasFilter.php (modified) (6 diffs)

trunk/tests/phpunit/tests/hooks/hasFilter.php

@@ -12 +12 @@
         $callback      = '__return_null';
         $hook          = new WP_Hook();
-        $tag           = __FUNCTION__;
+        $hook_name     = __FUNCTION__;
         $priority      = 1;
         $accepted_args = 2;
 
-        $hook->add_filter( $tag, $callback, $priority, $accepted_args );
+        $hook->add_filter( $hook_name, $callback, $priority, $accepted_args );
 
-        $this->assertSame( $priority, $hook->has_filter( $tag, $callback ) );
+        $this->assertSame( $priority, $hook->has_filter( $hook_name, $callback ) );
     }
 
@@ -25 +25 @@
         $callback      = array( $a, 'action' );
         $hook          = new WP_Hook();
-        $tag           = __FUNCTION__;
+        $hook_name     = __FUNCTION__;
         $priority      = 1;
         $accepted_args = 2;
 
-        $hook->add_filter( $tag, $callback, $priority, $accepted_args );
+        $hook->add_filter( $hook_name, $callback, $priority, $accepted_args );
 
-        $this->assertSame( $priority, $hook->has_filter( $tag, $callback ) );
+        $this->assertSame( $priority, $hook->has_filter( $hook_name, $callback ) );
     }
 
@@ -37 +37 @@
         $callback      = array( 'MockAction', 'action' );
         $hook          = new WP_Hook();
-        $tag           = __FUNCTION__;
+        $hook_name     = __FUNCTION__;
         $priority      = 1;
         $accepted_args = 2;
 
-        $hook->add_filter( $tag, $callback, $priority, $accepted_args );
+        $hook->add_filter( $hook_name, $callback, $priority, $accepted_args );
 
-        $this->assertSame( $priority, $hook->has_filter( $tag, $callback ) );
+        $this->assertSame( $priority, $hook->has_filter( $hook_name, $callback ) );
     }
 
@@ -49 +49 @@
         $callback      = '__return_null';
         $hook          = new WP_Hook();
-        $tag           = __FUNCTION__;
+        $hook_name     = __FUNCTION__;
         $priority      = 1;
         $accepted_args = 2;
 
-        $hook->add_filter( $tag, $callback, $priority, $accepted_args );
+        $hook->add_filter( $hook_name, $callback, $priority, $accepted_args );
 
         $this->assertTrue( $hook->has_filter() );
@@ -64 +64 @@
 
     public function test_not_has_filter_with_callback() {
-        $callback = '__return_null';
-        $hook     = new WP_Hook();
-        $tag      = __FUNCTION__;
+        $callback  = '__return_null';
+        $hook      = new WP_Hook();
+        $hook_name = __FUNCTION__;
 
-        $this->assertFalse( $hook->has_filter( $tag, $callback ) );
+        $this->assertFalse( $hook->has_filter( $hook_name, $callback ) );
     }
 
@@ -74 +74 @@
         $callback      = '__return_null';
         $hook          = new WP_Hook();
-        $tag           = __FUNCTION__;
+        $hook_name     = __FUNCTION__;
         $priority      = 1;
         $accepted_args = 2;
 
-        $hook->add_filter( $tag, $callback, $priority, $accepted_args );
+        $hook->add_filter( $hook_name, $callback, $priority, $accepted_args );
 
-        $this->assertFalse( $hook->has_filter( $tag, '__return_false' ) );
+        $this->assertFalse( $hook->has_filter( $hook_name, '__return_false' ) );
     }
 }