Changeset 53805 for trunk/tests/phpunit/tests/filters.php

Timestamp:

07/31/2022 04:25:27 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Update the terminology used for action or filter names in MockAction class.

This replaces the "tag" wording with "hook name" where appropriate, to match the core function signatures.

Includes:

• Introducing a ::get_hook_names() method instead of ::get_tags(), keeping the latter as an alias.
• Adding a hook_name key to the ::$events property, keeping tag for backward compatibility for now.
• Adding missing @since tags for class methods.

Follow-up to [24/tests], [62/tests], [70/tests], [50807], [53804].

See #55652.

File:

• trunk/tests/phpunit/tests/filters.php (modified) (7 diffs)

trunk/tests/phpunit/tests/filters.php

@@ -19 +19 @@
         $this->assertSame( 1, $a->get_call_count() );
         // Only our hook was called.
-        $this->assertSame( array( $hook_name ), $a->get_tags() );
+        $this->assertSame( array( $hook_name ), $a->get_hook_names() );
 
         $argsvar = $a->get_args();
@@ -36 +36 @@
         // Make sure our hook was called correctly.
         $this->assertSame( 1, $a->get_call_count() );
-        $this->assertSame( array( $hook_name ), $a->get_tags() );
+        $this->assertSame( array( $hook_name ), $a->get_hook_names() );
 
         // Now remove the filter, do it again, and make sure it's not called this time.
@@ -42 +42 @@
         $this->assertSame( $val, apply_filters( $hook_name, $val ) );
         $this->assertSame( 1, $a->get_call_count() );
-        $this->assertSame( array( $hook_name ), $a->get_tags() );
+        $this->assertSame( array( $hook_name ), $a->get_hook_names() );
 
     }
@@ -136 +136 @@
             // 'filter2' is called first because it has priority 9.
             array(
-                'filter' => 'filter2',
-                'tag'    => $hook_name,
-                'args'   => array( $val ),
+                'filter'    => 'filter2',
+                'hook_name' => $hook_name,
+                'tag'       => $hook_name, // Back compat.
+                'args'      => array( $val ),
             ),
             // 'filter' is called second.
             array(
-                'filter' => 'filter',
-                'tag'    => $hook_name,
-                'args'   => array( $val ),
+                'filter'    => 'filter',
+                'hook_name' => $hook_name,
+                'tag'       => $hook_name, // Back compat.
+                'args'      => array( $val ),
             ),
         );
@@ -193 +195 @@
         $this->assertSame( 4, $a->get_call_count() );
         // The right hooks should have been called in order.
-        $this->assertSame( array( $hook_name1, $hook_name2, $hook_name1, $hook_name1 ), $a->get_tags() );
+        $this->assertSame( array( $hook_name1, $hook_name2, $hook_name1, $hook_name1 ), $a->get_hook_names() );
 
         remove_filter( 'all', array( $a, 'filterall' ) );
@@ -212 +214 @@
         // Make sure our hook was called correctly.
         $this->assertSame( 1, $a->get_call_count() );
-        $this->assertSame( array( $hook_name ), $a->get_tags() );
+        $this->assertSame( array( $hook_name ), $a->get_hook_names() );
 
         // Now remove the filter, do it again, and make sure it's not called this time.
@@ -221 +223 @@
         // Call cound should remain at 1.
         $this->assertSame( 1, $a->get_call_count() );
-        $this->assertSame( array( $hook_name ), $a->get_tags() );
+        $this->assertSame( array( $hook_name ), $a->get_hook_names() );
     }