Changeset 53813 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

Timestamp:

08/03/2022 09:01:05 AM (2 years ago)

Author:

audrasjb

Message:

Posts, Post Types: Force unique slugs for draft posts.

This fixes a behavior where a draft created with the same slug as an existing post would set the existing post to a 404.

wp_unique_post_slug() returns the same slug for 'draft' or 'pending' posts, so to ensure that a unique slug is generated, this changeset adds the post data with the 'publish' status to wp_unique_post_slug().

Props Toro_Unit, h2ham, peterwilsoncc, costdev, antonvlasenko, azaozz, ironprogrammer, audrasjb, hellofromTonya.
Fixes #52422.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -654 +654 @@
         $prepared_post->post_type = $this->post_type;
 
+        if ( ! empty( $prepared_post->post_name )
+            && ! empty( $prepared_post->post_status )
+            && in_array( $prepared_post->post_status, array( 'draft', 'pending' ), true )
+        ) {
+            /*
+             * `wp_unique_post_slug()` returns the same
+             * slug for 'draft' or 'pending' posts.
+             *
+             * To ensure that a unique slug is generated,
+             * pass the post data with the 'publish' status.
+             */
+            $prepared_post->post_name = wp_unique_post_slug(
+                $prepared_post->post_name,
+                $prepared_post->id,
+                'publish',
+                $prepared_post->post_type,
+                $prepared_post->post_parent
+            );
+        }
+
         $post_id = wp_insert_post( wp_slash( (array) $prepared_post ), true, false );
 
@@ -833 +853 @@
         if ( is_wp_error( $post ) ) {
             return $post;
+        }
+
+        if ( ! empty( $post->post_status ) ) {
+            $post_status = $post->post_status;
+        } else {
+            $post_status = $post_before->post_status;
+        }
+
+        /*
+         * `wp_unique_post_slug()` returns the same
+         * slug for 'draft' or 'pending' posts.
+         *
+         * To ensure that a unique slug is generated,
+         * pass the post data with the 'publish' status.
+         */
+        if ( ! empty( $post->post_name ) && in_array( $post_status, array( 'draft', 'pending' ), true ) ) {
+            $post_parent     = ! empty( $post->post_parent ) ? $post->post_parent : 0;
+            $post->post_name = wp_unique_post_slug( $post->post_name, $post->ID, 'publish', $post->post_type, $post_parent );
         }