Changeset 53813 for trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

Timestamp:

08/03/2022 09:01:05 AM (2 years ago)

Author:

audrasjb

Message:

Posts, Post Types: Force unique slugs for draft posts.

This fixes a behavior where a draft created with the same slug as an existing post would set the existing post to a 404.

wp_unique_post_slug() returns the same slug for 'draft' or 'pending' posts, so to ensure that a unique slug is generated, this changeset adds the post data with the 'publish' status to wp_unique_post_slug().

Props Toro_Unit, h2ham, peterwilsoncc, costdev, antonvlasenko, azaozz, ironprogrammer, audrasjb, hellofromTonya.
Fixes #52422.

File:

• trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -5237 +5237 @@
     }
 
+    /**
+     * @ticket 52422
+     *
+     * @covers WP_REST_Request::create_item
+     */
+    public function test_draft_post_do_not_have_the_same_slug_as_existing_post() {
+        wp_set_current_user( self::$editor_id );
+        $this->factory()->post->create( array( 'post_name' => 'sample-slug' ) );
+
+        $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+        $params  = $this->set_post_data(
+            array(
+                'status' => 'draft',
+                'slug'   => 'sample-slug',
+            )
+        );
+        $request->set_body_params( $params );
+        $response = rest_get_server()->dispatch( $request );
+
+        $new_data = $response->get_data();
+        $this->assertSame(
+            'sample-slug-2',
+            $new_data['slug'],
+            'The slug from the REST response did not match'
+        );
+
+        $post = get_post( $new_data['id'] );
+
+        $this->assertSame(
+            'draft',
+            $post->post_status,
+            'The post status is not draft'
+        );
+
+        $this->assertSame(
+            'sample-slug-2',
+            $post->post_name,
+            'The post slug was not set to "sample-slug-2"'
+        );
+    }
+
     public function tear_down() {
         if ( isset( $this->attachment_id ) ) {