Changeset 53821 for trunk/tests/phpunit/tests/cache.php

Timestamp:

08/04/2022 12:09:03 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Add a unit test for WP_Object_Cache::is_valid_key().

A valid cache key for wp_cache_*() functions must be either an integer number or a non-empty string.

Follow-up to [53818].

See #56198.

File:

• trunk/tests/phpunit/tests/cache.php (modified) (2 diffs)

trunk/tests/phpunit/tests/cache.php

@@ -27 +27 @@
     }
 
+    /**
+     * @ticket 56198
+     *
+     * @covers WP_Object_Cache::is_valid_key
+     * @dataProvider data_is_valid_key
+     */
+    public function test_is_valid_key( $key, $valid ) {
+        if ( wp_using_ext_object_cache() ) {
+            $this->markTestSkipped( 'This test requires that an external object cache is not in use.' );
+        }
+
+        $val = 'val';
+
+        if ( $valid ) {
+            $this->assertTrue( $this->cache->add( $key, $val ), 'WP_Object_Cache:add() should return true for valid keys.' );
+            $this->assertSame( $val, $this->cache->get( $key ), 'The retrieved value should match the added value.' );
+        } else {
+            $this->setExpectedIncorrectUsage( 'WP_Object_Cache::add' );
+            $this->assertFalse( $this->cache->add( $key, $val ), 'WP_Object_Cache:add() should return false for invalid keys.' );
+        }
+    }
+
+    /**
+     * Data provider for test_is_valid_key().
+     *
+     * @return array[] Test parameters {
+     *     @type mixed $key   Cache key value.
+     *     @type bool  $valid Whether the key should be considered valid.
+     * }
+     */
+    public function data_is_valid_key() {
+        return array(
+            array( false, false ),
+            array( null, false ),
+            array( '', false ),
+            array( 0, true ),
+            array( 1, true ),
+            array( '0', true ),
+            array( 'key', true ),
+        );
+    }
+
     public function test_miss() {
         $this->assertFalse( $this->cache->get( 'test_miss' ) );
@@ -113 +155 @@
 
     public function test_flush() {
-        global $_wp_using_ext_object_cache;
-
-        if ( $_wp_using_ext_object_cache ) {
+        if ( wp_using_ext_object_cache() ) {
             $this->markTestSkipped( 'This test requires that an external object cache is not in use.' );
         }