Changeset 53836 for trunk/tests/phpunit/tests/link/editTermLink.php

Timestamp:

08/04/2022 06:28:33 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Combine test classes for get_edit_term_link() tests.

There were two sets of tests for the function:

• One in the link directory, based on the link-template.php file name.
• One in the term directory, based on the component name.

To avoid confusion and make it easier to decide where new tests should go in the future, the existing tests are now combined in the former location.

Includes:

• Setting the current user in ::set_up() instead of each individual test method.
• Changing the custom taxonomy name to wptests_tax for consistency with other tests.
• Moving ::register_custom_taxonomy() and ::get_term() helpers to the beginning of the class.

Follow-up to [32954], [36646], [52180], [52255], [53833].

See #55652.

File:

• trunk/tests/phpunit/tests/link/editTermLink.php (modified) (6 diffs)

trunk/tests/phpunit/tests/link/editTermLink.php

@@ -13 +13 @@
                 self::register_custom_taxonomy();
 
-                $taxonomies = array( 'category', 'post_tag', 'custom_taxonomy' );
+                $taxonomies = array( 'category', 'post_tag', 'wptests_tax' );
                 foreach ( $taxonomies as $taxonomy ) {
                         self::$terms[ $taxonomy ] = $factory->term->create_and_get( array( 'taxonomy' => $taxonomy ) );
@@ -24 +24 @@
         public function set_up() {
                 parent::set_up();
+                wp_set_current_user( self::$user_ids['admin'] );
                 self::register_custom_taxonomy();
+        }
+
+        /**
+         * Helper to register a custom taxonomy for use in tests.
+         *
+         * @since 5.9.0
+         */
+        private static function register_custom_taxonomy() {
+                register_taxonomy( 'wptests_tax', 'post' );
+        }
+
+        /**
+         * Helper to get the term for the given taxonomy.
+         *
+         * @since 5.9.0
+         *
+         * @param string $taxonomy Taxonomy being tested (used for index of term keys).
+         * @param bool   $use_id   When true, pass term ID. Else, pass term object.
+         * @return WP_Term|int If $use_id is true, term ID is returned; else instance of WP_Term.
+         */
+        private function get_term( $taxonomy, $use_id ) {
+                $term = self::$terms[ $taxonomy ];
+                if ( $use_id ) {
+                        $term = $term->term_id;
+                }
+
+                return $term;
         }
 
@@ -37 +65 @@
          */
         public function test_edit_term_link_for_permitted_user( $taxonomy, $use_id, $expected ) {
-                wp_set_current_user( self::$user_ids['admin'] );
                 $term = $this->get_term( $taxonomy, $use_id );
 
@@ -73 +100 @@
          */
         public function test_edit_term_link_filter_is_int_by_term_id( $taxonomy, $use_id ) {
-                wp_set_current_user( self::$user_ids['admin'] );
                 $term = $this->get_term( $taxonomy, $use_id );
 
@@ -97 +123 @@
          */
         public function test_edit_term_link_filter_is_int_by_term_object( $taxonomy, $use_id ) {
-                wp_set_current_user( self::$user_ids['admin'] );
                 $term = $this->get_term( $taxonomy, $use_id );
 
@@ -140 +165 @@
                         ),
                         'a custom taxonomy passing term_id'     => array(
-                                'taxonomy' => 'custom_taxonomy',
+                                'taxonomy' => 'wptests_tax',
                                 'use_id'   => true,
-                                'expected' => 'term.php?taxonomy=custom_taxonomy&tag_ID=%ID%&post_type=post',
+                                'expected' => 'term.php?taxonomy=wptests_tax&tag_ID=%ID%&post_type=post',
                         ),
                         'a custom taxonomy passing term object' => array(
-                                'taxonomy' => 'custom_taxonomy',
+                                'taxonomy' => 'wptests_tax',
                                 'use_id'   => false,
-                                'expected' => 'term.php?taxonomy=custom_taxonomy&tag_ID=%ID%&post_type=post',
+                                'expected' => 'term.php?taxonomy=wptests_tax&tag_ID=%ID%&post_type=post',
                         ),
                 );
         }
-
-        /**
-         * Helper to register a custom taxonomy for use in tests.
-         *
-         * @since 5.9.0
-         */
-        private static function register_custom_taxonomy() {
-                register_taxonomy( 'custom_taxonomy', 'post' );
-        }
-
-        /**
-         * Helper to get the term for the given taxonomy.
-         *
-         * @since 5.9.0
-         *
-         * @param string $taxonomy Taxonomy being tested (used for index of term keys).
-         * @param bool   $use_id   When true, pass term ID. Else, pass term object.
-         * @return WP_Term|int If $use_id is true, term ID is returned; else instance of WP_Term.
-         */
-        private function get_term( $taxonomy, $use_id ) {
-                $term = self::$terms[ $taxonomy ];
-                if ( $use_id ) {
-                        $term = $term->term_id;
-                }
-
-                return $term;
-        }
 }