Changeset 53840

Timestamp:

08/05/2022 06:10:04 AM (4 years ago)

Author:

audrasjb

Message:

Coding standards: Properly escape URLs returned by self_admin_url() calls.

This address some other echoed instances missed by [53839].

Fixes #56329.

Location:

trunk/src/wp-admin

Files:

• includes/plugin-install.php (modified) (1 diff)
• update-core.php (modified) (3 diffs)

trunk/src/wp-admin/includes/plugin-install.php

@@ -828 +828 @@
                                 /* translators: %s: URL to WordPress Updates screen. */
                                 ' ' . __( '<a href="%s" target="_parent">Click here to update WordPress</a>.' ),
-                                self_admin_url( 'update-core.php' )
+                                esc_url( self_admin_url( 'update-core.php' ) )
                         );
                 }

trunk/src/wp-admin/update-core.php

@@ -687 +687 @@
                                         /* translators: 1: URL to WordPress Updates screen, 2: URL to Update PHP page. */
                                         __( '<a href="%1$s">Please update WordPress</a>, and then <a href="%2$s">learn more about updating PHP</a>.' ),
-                                        self_admin_url( 'update-core.php' ),
+                                        esc_url( self_admin_url( 'update-core.php' ) ),
                                         esc_url( wp_get_update_php_url() )
                                 );
@@ -700 +700 @@
                                         /* translators: %s: URL to WordPress Updates screen. */
                                         __( '<a href="%s">Please update WordPress</a>.' ),
-                                        self_admin_url( 'update-core.php' )
+                                        esc_url( self_admin_url( 'update-core.php' ) )
                                 );
                         } elseif ( current_user_can( 'update_php' ) ) {
@@ -721 +721 @@
                                         /* translators: %s: URL to WordPress Updates screen. */
                                         __( '<a href="%s">Please update WordPress</a>.' ),
-                                        self_admin_url( 'update-core.php' )
+                                        esc_url( self_admin_url( 'update-core.php' ) )
                                 );
                         }