Changeset 53848

Timestamp:

08/05/2022 10:14:09 PM (4 years ago)

Author:

adamsilverstein

Message:

Media: use original image size data for full size secondary mime generation.

Correct an issue where the secondary mime type full size image would not be properly resized (and -scaled added to the name) when the original upload is over the big_image_size_threshold dimensions.

Props mukesh27.
See #55443.

File:

• trunk/src/wp-admin/includes/image.php (modified) (1 diff)

trunk/src/wp-admin/includes/image.php

@@ -342 +342 @@
 
         if ( ! empty( $additional_mime_types ) ) {
-                // Use the original file's exif_meta orientation information for secondary mime generation.
-                $saved_orientation                       = $image_meta['image_meta']['orientation'];
+                // Use the original file's exif_meta orientation and size information for secondary mime generation to ensure
+                // sub-sized images are correctly scaled and rotated.
+
+                // Save data.
+                $saved_meta                = array();
+                $saved_meta['orientation'] = $image_meta['image_meta']['orientation'];
+                $saved_meta['width']       = $image_meta['width'];
+                $saved_meta['height']      = $image_meta['height'];
+
+                // Temporarily set the image meta to the original file's meta.
                 $image_meta['image_meta']['orientation'] = $exif_meta['orientation'];
-                $image_meta                              = _wp_make_additional_mime_types( $additional_mime_types, $file, $image_meta, $attachment_id );
-                $image_meta['image_meta']['orientation'] = $saved_orientation;
+                $image_meta['width']                     = $imagesize[0];
+                $image_meta['height']                    = $imagesize[1];
+
+                $image_meta = _wp_make_additional_mime_types( $additional_mime_types, $file, $image_meta, $attachment_id );
+
+                // Restore the saved meta data.
+                $image_meta['image_meta']['orientation'] = $saved_meta['orientation'];
+                $image_meta['width']                     = $saved_meta['width'];
+                $image_meta['height']                    = $saved_meta['height'];
 
         }