Changeset 53852

Timestamp:

08/07/2022 02:32:55 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Remove dynamic properties in Tests_Media_GetPostGalleries.

Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

In this particular case, the test class contains a set_up() method that sets the $img_meta property, which is used by the tests, but never changed by the tests.

In other words, setting this property in the set_up() is an unnecessary overhead and the property should be changed to a class constant.

Includes renaming the test class to match the ​naming conventions.

Follow-up to [52190], [53557], [53558], [53850], [53851].

Props jrf.
See #56033.

File:

• trunk/tests/phpunit/tests/media/getPostGalleries.php (modified) (5 diffs)

trunk/tests/phpunit/tests/media/getPostGalleries.php

@@ -5 +5 @@
  * @covers ::get_post_galleries
  */
-class Tests_Functions_getPostGalleries extends WP_UnitTestCase {
-
-    public function set_up() {
-        parent::set_up();
-        $this->img_meta = array(
-            'width'  => 100,
-            'height' => 100,
-            'sizes'  => '',
-        );
-    }
+class Tests_Media_GetPostGalleries extends WP_UnitTestCase {
+
+    const IMG_META = array(
+        'width'  => 100,
+        'height' => 100,
+        'sizes'  => '',
+    );
 
     /**
@@ -570 +567 @@
                 )
             );
-            $metadata      = array_merge( array( 'file' => "image$i.jpg" ), $this->img_meta );
+            $metadata      = array_merge( array( 'file' => "image$i.jpg" ), self::IMG_META );
             wp_update_attachment_metadata( $attachment_id, $metadata );
             $ids[]      = $attachment_id;
@@ -659 +656 @@
             )
         );
-        $metadata       = array_merge( array( 'file' => 'image1.jpg' ), $this->img_meta );
+        $metadata       = array_merge( array( 'file' => 'image1.jpg' ), self::IMG_META );
         $url            = 'http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/' . 'image1.jpg';
         $global_post_id = $this->factory->post->create(
@@ -839 +836 @@
                 )
             );
-            $metadata      = array_merge( array( 'file' => "image$i.jpg" ), $this->img_meta );
+            $metadata      = array_merge( array( 'file' => "image$i.jpg" ), self::IMG_META );
             wp_update_attachment_metadata( $attachment_id, $metadata );
             $ids[]      = $attachment_id;
@@ -903 +900 @@
                 )
             );
-            $metadata      = array_merge( array( 'file' => "image$i.jpg" ), $this->img_meta );
+            $metadata      = array_merge( array( 'file' => "image$i.jpg" ), self::IMG_META );
             wp_update_attachment_metadata( $attachment_id, $metadata );
             $ids[]      = $attachment_id;