Changeset 53853

Timestamp:

08/07/2022 02:41:04 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Remove dynamic properties in Tests_Post_Revisions.

Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

In this particular case, the test class contains a set_up() method that sets the $post_type property, which is used by the tests, but never changed by the tests.

In other words, setting this property in the set_up() is an unnecessary overhead and the property should be changed to a class constant.

Follow-up to [1212/tests], [52389], [53557], [53558], [53850], [53851], [53852].

Props jrf.
See #56033.

File:

• trunk/tests/phpunit/tests/post/revisions.php (modified) (10 diffs)

trunk/tests/phpunit/tests/post/revisions.php

@@ -6 +6 @@
  */
 class Tests_Post_Revisions extends WP_UnitTestCase {
+
+        const POST_TYPE = 'test-revision';
+
         protected static $admin_user_id;
         protected static $editor_user_id;
@@ -14 +17 @@
                 self::$editor_user_id = $factory->user->create( array( 'role' => 'editor' ) );
                 self::$author_user_id = $factory->user->create( array( 'role' => 'author' ) );
-        }
-
-        public function set_up() {
-                parent::set_up();
-                $this->post_type = 'test-revision';
         }
 
@@ -319 +317 @@
         public function test_revision_view_caps_cpt() {
                 register_post_type(
-                        $this->post_type,
+                        self::POST_TYPE,
                         array(
                                 'capability_type' => 'event',
@@ -329 +327 @@
                 $post_id = self::factory()->post->create(
                         array(
-                                'post_type'   => $this->post_type,
+                                'post_type'   => self::POST_TYPE,
                                 'post_author' => self::$editor_user_id,
                         )
@@ -361 +359 @@
         public function test_revision_restore_caps_cpt() {
                 register_post_type(
-                        $this->post_type,
+                        self::POST_TYPE,
                         array(
                                 'capability_type' => 'event',
@@ -376 +374 @@
                 $post_id = self::factory()->post->create(
                         array(
-                                'post_type'   => $this->post_type,
+                                'post_type'   => self::POST_TYPE,
                                 'post_author' => self::$editor_user_id,
                         )
@@ -407 +405 @@
         public function test_revision_restore_caps_before_publish() {
                 register_post_type(
-                        $this->post_type,
+                        self::POST_TYPE,
                         array(
                                 'capability_type' => 'post',
@@ -425 +423 @@
                 $post_id = self::factory()->post->create(
                         array(
-                                'post_type'   => $this->post_type,
+                                'post_type'   => self::POST_TYPE,
                                 'post_status' => 'draft',
                         )
@@ -467 +465 @@
         public function test_revision_diff_caps_cpt() {
                 register_post_type(
-                        $this->post_type,
+                        self::POST_TYPE,
                         array(
                                 'capability_type' => 'event',
@@ -477 +475 @@
                 $post_id = self::factory()->post->create(
                         array(
-                                'post_type'   => $this->post_type,
+                                'post_type'   => self::POST_TYPE,
                                 'post_author' => self::$editor_user_id,
                         )