Changeset 53854 for trunk/tests/phpunit/tests/file.php

Timestamp:

08/07/2022 02:48:42 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Remove dynamic properties in Tests_File.

Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

In this case, as the $badchars property never changes, declaring this as a class constant is the sensible option.

As for the $dir property (which cannot be turned into a constant due to the function call), this is used in multiple tests, so making this property explicit makes sense.

Follow-up to [139/tests], [53557], [53558], [53850], [53851], [53852], [53853].

Props jrf.
See #56033.

File:

• trunk/tests/phpunit/tests/file.php (modified) (2 diffs)

trunk/tests/phpunit/tests/file.php

@@ -6 +6 @@
 class Tests_File extends WP_UnitTestCase {
 
+    const BADCHARS = '"\'[]*&?$';
+
+    private $dir;
+
     public function set_up() {
         parent::set_up();
 
         $this->dir = untrailingslashit( get_temp_dir() );
-
-        $this->badchars = '"\'[]*&?$';
     }
 
@@ -138 +140 @@
     public function test_unique_filename_is_sanitized() {
         $name     = __FUNCTION__;
-        $filename = wp_unique_filename( $this->dir, $name . $this->badchars . '.txt' );
+        $filename = wp_unique_filename( $this->dir, $name . self::BADCHARS . '.txt' );
 
         // Make sure the bad characters were all stripped out.