Changeset 53861 for trunk/tests/phpunit/tests/query.php

Timestamp:

08/08/2022 02:38:08 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Improve the test for not throwing a warning on malformed date queries.

• Make it specifically about wp_resolve_numeric_slug_conflicts(), the function that was throwing an Undefined array key "year" PHP warning for malformed date requests.
• Move the test under the rewrite component and make its name a bit more descriptive.
• Check the return result of the function instead of performing a dummy assertion.
• Use named array keys in the data provider for clarity.
• Add missing @covers tag.

Follow-up to [32648], [53857].

Props costdev, peterwilsoncc, 1naveengiri, mukesh27, SergeyBiryukov.
See #52252, #45513.

File:

• trunk/tests/phpunit/tests/query.php (modified) (3 diffs)

trunk/tests/phpunit/tests/query.php

@@ -2 +2 @@
 
 class Tests_Query extends WP_UnitTestCase {
-
-    /**
-     * Fixed date post ID.
-     *
-     * @var int
-     */
-    public static $post_with_date;
 
     public function set_up() {
@@ -15 +8 @@
         $this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
         create_initial_taxonomies();
-    }
-
-    public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
-        self::$post_with_date = $factory->post->create(
-            array(
-                'post_date' => '2020-01-05 12:00:00',
-                'post_name' => 'post-with-date',
-            )
-        );
     }
 
@@ -715 +699 @@
 
     /**
-     * @ticket 52252
-     * @dataProvider data_malformed_date_queries
-     *
-     * @param string $permalink_structure Permalink structure.
-     * @param array $query_vars Querystring parameteres.
-     */
-    public function test_malformed_date_queries( $permalink_structure, $query_vars ) {
-        $this->set_permalink_structure( $permalink_structure );
-        $this->go_to( add_query_arg( $query_vars, home_url() ) );
-
-        /*
-         * Ticket 52252 was to prevent notices from being thrown
-         * if the date query is malformed.
-         *
-         * The test will automatically fail if the function triggers a notice,
-         * so this dummy assertion is just for accurate stats.
-         */
-        $this->assertTrue( true );
-    }
-
-    /**
-     * Data provider for test_malformed_date_queries.
-     *
-     * @return array Test data.
-     */
-    public function data_malformed_date_queries() {
-        return array(
-            '/%postname%/ with missing year'         => array(
-                '/%postname%/',
-                array(
-                    'monthnum' => 1,
-                    'day'      => 15,
-                ),
-            ),
-            '/%postname%/ with month only'           => array(
-                '/%postname%/',
-                array(
-                    'monthnum' => 1,
-                ),
-            ),
-            '/%year%/%postname%/ with missing month' => array(
-                '/%year%/%postname%/',
-                array(
-                    'year' => 2020,
-                    'day'  => 15,
-                ),
-            ),
-        );
-    }
-
-    /**
      * @ticket 55100
      */