Changeset 53868 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

08/09/2022 12:31:09 AM (4 years ago)

Author:

peterwilsoncc

Message:

Administration: Improve performance of List Tables.

Improve the performance of WP_List_Table::get_column_info() by adding the primary column to the cached header values. This reduces the number of calls to the WP_List_Table::get_primary_column_name() method to once per table in line with the other header getter functions.

Props bobbingwide, chaion07, costdev, mikeschroder, mukesh27, peterwilsoncc, shetheliving, spacedmonkey.
Fixes #34564.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -1109 +1109 @@
         protected function get_column_info() {
                 // $_column_headers is already set / cached.
-                if ( isset( $this->_column_headers ) && is_array( $this->_column_headers ) ) {
+                if (
+                        isset( $this->_column_headers ) &&
+                        is_array( $this->_column_headers )
+                ) {
                         /*
                          * Backward compatibility for `$_column_headers` format prior to WordPress 4.3.
@@ -1117 +1120 @@
                          * in plugins setting the property directly in the three item format.
                          */
+                        if ( 4 === count( $this->_column_headers ) ) {
+                                return $this->_column_headers;
+                        }
+
                         $column_headers = array( array(), array(), array(), $this->get_primary_column_name() );
                         foreach ( $this->_column_headers as $key => $value ) {
@@ -1122 +1129 @@
                         }
 
-                        return $column_headers;
+                        $this->_column_headers = $column_headers;
+
+                        return $this->_column_headers;
                 }