Make WordPress Core

08/11/2022 12:37:05 PM (22 months ago)

I18N: Introduce WP_Textdomain_Registry to store text domains and their language directory paths.

Previously, when using switch_to_locale() all current loaded text domains were unloaded and added to the $l10n_unloaded global. This prevented the just-in-time loading for text domains after a switch. The just-in-time loading was also only possible if the translations were stored in WP_LANG_DIR. Both issues have been fixed.

  • Adds WP_Textdomain_Registry to keep track of the language directory paths for all plugins and themes.
  • Updates all load_*_textdomain() functions to store the path in WP_Textdomain_Registry.
  • Adds $locale parameter to load_textdomain() to specify the locale the translation file is for.
  • Adds $reloadable parameter to unload_textdomain() to define whether a text domain can be loaded just-in-time again. This is used by WP_Locale_Switcher::load_translations().
  • Extends _load_textdomain_just_in_time() to also support text domains of plugins and themes with custom language directories.
  • Fixes the incorrect test_plugin_translation_after_switching_locale_twice() test which should have caught this issue earlier.
  • Adds a new test plugin and theme to test the loading of translations with a custom language directory.
  • Deprecates the now unused and private _get_path_to_translation() and _get_path_to_translation_from_lang_dir() functions.

Previously added in [49236] and reverted in [49236] to investigate concerns which are now addressed here.

Props yoavf, swissspidy, dd32, ocean90.
See #26511.
Fixes #39210.

1 edited


  • trunk/src/wp-settings.php

    r53152 r53874  
    153153// Load the L10n library.
    154154require_once ABSPATH . WPINC . '/l10n.php';
     155require_once ABSPATH . WPINC . '/class-wp-textdomain-registry.php';
    155156require_once ABSPATH . WPINC . '/class-wp-locale.php';
    156157require_once ABSPATH . WPINC . '/class-wp-locale-switcher.php';
    335336$GLOBALS['wp_embed'] = new WP_Embed();
     339 * WordPress Textdomain Registry object.
     340 *
     341 * Used to support just-in-time translations for manually loaded text domains.
     342 *
     343 * @since 6.1.0
     344 *
     345 * @global WP_Textdomain_Registry $wp_textdomain_registry WordPress Textdomain Registry.
     346 */
     347$GLOBALS['wp_textdomain_registry'] = new WP_Textdomain_Registry();
    337349// Load multisite-specific files.
    338350if ( is_multisite() ) {
Note: See TracChangeset for help on using the changeset viewer.