Changeset 53874 for trunk/tests/phpunit/tests/l10n/loadTextdomainJustInTime.php

Timestamp:

08/11/2022 12:37:05 PM (2 years ago)

Author:

swissspidy

Message:

I18N: Introduce WP_Textdomain_Registry to store text domains and their language directory paths.

Previously, when using switch_to_locale() all current loaded text domains were unloaded and added to the $l10n_unloaded global. This prevented the just-in-time loading for text domains after a switch. The just-in-time loading was also only possible if the translations were stored in WP_LANG_DIR. Both issues have been fixed.

• Adds WP_Textdomain_Registry to keep track of the language directory paths for all plugins and themes.
• Updates all load_*_textdomain() functions to store the path in WP_Textdomain_Registry.
• Adds $locale parameter to load_textdomain() to specify the locale the translation file is for.
• Adds $reloadable parameter to unload_textdomain() to define whether a text domain can be loaded just-in-time again. This is used by WP_Locale_Switcher::load_translations().
• Extends _load_textdomain_just_in_time() to also support text domains of plugins and themes with custom language directories.
• Fixes the incorrect test_plugin_translation_after_switching_locale_twice() test which should have caught this issue earlier.
• Adds a new test plugin and theme to test the loading of translations with a custom language directory.
• Deprecates the now unused and private _get_path_to_translation() and _get_path_to_translation_from_lang_dir() functions.

Previously added in [49236] and reverted in [49236] to investigate concerns which are now addressed here.

Props yoavf, swissspidy, dd32, ocean90.
See #26511.
Fixes #39210.

File:

• trunk/tests/phpunit/tests/l10n/loadTextdomainJustInTime.php (modified) (4 diffs)

trunk/tests/phpunit/tests/l10n/loadTextdomainJustInTime.php

@@ -33 +33 @@
         add_filter( 'template_root', array( $this, 'filter_theme_root' ) );
         wp_clean_themes_cache();
-        unset( $GLOBALS['wp_themes'] );
-        unset( $GLOBALS['l10n'] );
-        unset( $GLOBALS['l10n_unloaded'] );
-        _get_path_to_translation( null, true );
+        unset( $GLOBALS['wp_themes'], $GLOBALS['l10n'], $GLOBALS['l10n_unloaded'] );
+
+        /** @var WP_Textdomain_Registry $wp_textdomain_registry */
+        global $wp_textdomain_registry;
+
+        $wp_textdomain_registry->reset();
     }
 
@@ -42 +44 @@
         $GLOBALS['wp_theme_directories'] = $this->orig_theme_dir;
         wp_clean_themes_cache();
-        unset( $GLOBALS['wp_themes'] );
-        unset( $GLOBALS['l10n'] );
-        unset( $GLOBALS['l10n_unloaded'] );
-        _get_path_to_translation( null, true );
+        unset( $GLOBALS['wp_themes'], $GLOBALS['l10n'], $GLOBALS['l10n_unloaded'] );
+
+        /** @var WP_Textdomain_Registry $wp_textdomain_registry */
+        global $wp_textdomain_registry;
+
+        $wp_textdomain_registry->reset();
 
         parent::tear_down();
@@ -178 +182 @@
     /**
      * @ticket 37997
+     * @ticket 39210
      *
      * @covers ::switch_to_locale
@@ -193 +198 @@
 
         $this->assertSame( 'Das ist ein Dummy Plugin', $actual_de_de );
-        $this->assertSame( 'This is a dummy plugin', $actual_es_es );
+        $this->assertSame( 'Este es un plugin dummy', $actual_es_es );
     }