Changeset 53888 for trunk/src/wp-admin/includes/media.php

Timestamp:

08/12/2022 12:09:10 PM (2 years ago)

Author:

audrasjb

Message:

General: Add required fields helper functions for better reusability.

This changeset introduces new wp_required_field_indicator() and wp_required_field_message() helper functions to generate reusable and consistent required field indicator and message. It also implements these functions in various admin screens.

Props sabernhardt, ryokuhi, joedolson, audrasjb, SergeyBiryukov.
Fixes #54394.

File:

• trunk/src/wp-admin/includes/media.php (modified) (7 diffs)

trunk/src/wp-admin/includes/media.php

@@ -1704 +1704 @@
         <tr><td style='display:none' colspan='2' class='image-editor' id='image-editor-$post->ID'></td></tr>\n
         <tr><td colspan='2'><p class='media-types media-types-required-info'>" .
-            /* translators: %s: Asterisk symbol (*). */
-            sprintf( __( 'Required fields are marked %s' ), '<span class="required">*</span>' ) .
+            wp_required_field_message() .
         "</p></td></tr>\n";
 
@@ -1785 +1784 @@
         }
 
-        $required      = $field['required'] ? '<span class="required">*</span>' : '';
+        $required      = $field['required'] ? ' ' . wp_required_field_indicator() : '';
         $required_attr = $field['required'] ? ' required' : '';
         $class         = $id;
@@ -1976 +1975 @@
 
         $readonly      = ! $user_can_edit && ! empty( $field['taxonomy'] ) ? " readonly='readonly' " : '';
-        $required      = $field['required'] ? '<span class="required">*</span>' : '';
+        $required      = $field['required'] ? ' ' . wp_required_field_indicator() : '';
         $required_attr = $field['required'] ? ' required' : '';
         $class         = 'compat-field-' . $id;
@@ -2032 +2031 @@
     if ( $item ) {
         $item = '<p class="media-types media-types-required-info">' .
-            /* translators: %s: Asterisk symbol (*). */
-            sprintf( __( 'Required fields are marked %s' ), '<span class="required">*</span>' ) .
+            wp_required_field_message() .
             '</p>' .
             '<table class="compat-attachment-fields">' . $item . '</table>';
@@ -2930 +2928 @@
     <p class="media-types"><label><input type="radio" name="media_type" value="image" id="image-only"' . checked( 'image-only', $view, false ) . ' /> ' . __( 'Image' ) . '</label> &nbsp; &nbsp; <label><input type="radio" name="media_type" value="generic" id="not-image"' . checked( 'not-image', $view, false ) . ' /> ' . __( 'Audio, Video, or Other File' ) . '</label></p>
     <p class="media-types media-types-required-info">' .
-        /* translators: %s: Asterisk symbol (*). */
-        sprintf( __( 'Required fields are marked %s' ), '<span class="required">*</span>' ) .
+        wp_required_field_message() .
     '</p>
     <table class="describe ' . $table_class . '"><tbody>
         <tr>
             <th scope="row" class="label" style="width:130px;">
-                <label for="src"><span class="alignleft">' . __( 'URL' ) . '</span> <span class="required">*</span></label>
+                <label for="src"><span class="alignleft">' . __( 'URL' ) . '</span> ' . wp_required_field_indicator() . '</label>
                 <span class="alignright" id="status_img"></span>
             </th>
@@ -2944 +2941 @@
         <tr>
             <th scope="row" class="label">
-                <label for="title"><span class="alignleft">' . __( 'Title' ) . '</span> <span class="required">*</span></label>
+                <label for="title"><span class="alignleft">' . __( 'Title' ) . '</span> ' . wp_required_field_indicator() . '</label>
             </th>
             <td class="field"><input id="title" name="title" value="" type="text" required /></td>
@@ -2953 +2950 @@
         <tr class="image-only">
             <th scope="row" class="label">
-                <label for="alt"><span class="alignleft">' . __( 'Alternative Text' ) . '</span></label>
+                <label for="alt"><span class="alignleft">' . __( 'Alternative Text' ) . '</span> ' . wp_required_field_indicator() . '</label>
             </th>
             <td class="field"><input id="alt" name="alt" value="" type="text" required />