Changeset 53908

Timestamp:

08/19/2022 01:09:12 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Themes: Include a hyphen in the Block Themes tab key on Add Themes screen.

This better matches the tab name and changes the associated action hooks to:

• install_themes_pre_block-themes (fires before the tab is rendered)
• install_themes_block-themes (fires at the top the tab)

While including a mix of underscores and hyphens in a hook name is not quite typical for core, it does have a precedent and brings more consistency with similar filters on Add Plugin screen:

• install_plugins_pre_plugin-information
• install_plugins_plugin-information

Follow-up to [53906], [53907].

Fixes #56283.

Location:

trunk/src

Files:

• js/_enqueues/wp/theme.js (modified) (1 diff)
• wp-admin/theme-install.php (modified) (5 diffs)

trunk/src/js/_enqueues/wp/theme.js

@@ -1695 +1695 @@
         // Create a new collection with the proper theme data
         // for each section.
-        if ( 'blockthemes' === section ) {
+        if ( 'block-themes' === section ) {
             // Get the themes by sending Ajax POST request to api.wordpress.org/themes
             // or searching the local cache.

trunk/src/wp-admin/theme-install.php

@@ -91 +91 @@
      * Possible hook names include:
      *
-     *  - `install_themes_pre_blockthemes`
+     *  - `install_themes_pre_block-themes`
      *  - `install_themes_pre_dashboard`
      *  - `install_themes_pre_featured`
@@ -100 +100 @@
      *
      * @since 2.8.0
-     * @since 6.1.0 Added `install_themes_pre_blockthemes` hook name.
+     * @since 6.1.0 Added the `install_themes_pre_block-themes` hook name.
      */
     do_action( "install_themes_pre_{$tab}" );
@@ -188 +188 @@
             <li><a href="#" data-sort="popular"><?php _ex( 'Popular', 'themes' ); ?></a></li>
             <li><a href="#" data-sort="new"><?php _ex( 'Latest', 'themes' ); ?></a></li>
-            <li><a href="#" data-sort="blockthemes"><?php _ex( 'Block Themes', 'themes' ); ?></a></li>
+            <li><a href="#" data-sort="block-themes"><?php _ex( 'Block Themes', 'themes' ); ?></a></li>
             <li><a href="#" data-sort="favorites"><?php _ex( 'Favorites', 'themes' ); ?></a></li>
         </ul>
@@ -267 +267 @@
      * Possible hook names include:
      *
-     *  - `install_themes_blockthemes`
+     *  - `install_themes_block-themes`
      *  - `install_themes_dashboard`
      *  - `install_themes_featured`
@@ -276 +276 @@
      *
      * @since 2.8.0
-     * @since 6.1.0 Added `install_themes_blockthemes` hook name.
+     * @since 6.1.0 Added the `install_themes_block-themes` hook name.
      *
      * @param int $paged Number of the current page of results being viewed.