Changeset 53909

Timestamp:

08/19/2022 04:13:38 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Assign created fixtures to the dedicated class properties in some test classes.

This affects:

• WP_Test_REST_Categories_Controller
• WP_Test_REST_Comments_Controller
• WP_Test_REST_Tags_Controller

and brings consistency with:

• WP_Test_REST_Posts_Controller
• WP_Test_REST_Users_Controller

These test classes were previously updated to improve performance by creating less fixtures and reusing them where possible. While the pagination tests for categories and comments still passed due to enough items being created, the pagination test for tags did not work as expected and did not perform any assertions due to trying to iterate over an empty array of results.

This is now corrected by assigning the properties as intended and adding more assertions to the affected test.

Follow-up to [46657].

Props johnregan3, costdev, johnbillion.
See #54662.

Location:

trunk/tests/phpunit/tests/rest-api

Files:

• rest-categories-controller.php (modified) (1 diff)
• rest-comments-controller.php (modified) (1 diff)
• rest-tags-controller.php (modified) (3 diffs)

trunk/tests/phpunit/tests/rest-api/rest-categories-controller.php

@@ -39 +39 @@
                 // Set up categories for pagination tests.
                 for ( $i = 0; $i < self::$total_categories - 1; $i++ ) {
-                        $category_ids[] = $factory->category->create(
+                        self::$category_ids[] = $factory->category->create(
                                 array(
                                         'name' => "Category {$i}",

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -118 +118 @@
                 // Set up comments for pagination tests.
                 for ( $i = 0; $i < self::$total_comments - 1; $i++ ) {
-                        $comment_ids[] = $factory->comment->create(
+                        self::$comment_ids[] = $factory->comment->create(
                                 array(
                                         'comment_content' => "Comment {$i}",

trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php

@@ -55 +55 @@
                 // Set up tags for pagination tests.
                 for ( $i = 0; $i < self::$total_tags; $i++ ) {
-                        $tag_ids[] = $factory->tag->create(
+                        self::$tag_ids[] = $factory->tag->create(
                                 array(
                                         'name' => "Tag {$i}",
@@ -413 +413 @@
                 $tags     = $response->get_data();
 
+                $this->assertNotEmpty( $tags );
+
                 $i = 0;
                 foreach ( $tags as $tag ) {
@@ -426 +428 @@
                 $response = rest_get_server()->dispatch( $request );
                 $tags     = $response->get_data();
+
+                $this->assertNotEmpty( $tags );
 
                 foreach ( $tags as $tag ) {