Make WordPress Core

Changeset 53909


Ignore:
Timestamp:
08/19/2022 04:13:38 PM (21 months ago)
Author:
SergeyBiryukov
Message:

Tests: Assign created fixtures to the dedicated class properties in some test classes.

This affects:

  • WP_Test_REST_Categories_Controller
  • WP_Test_REST_Comments_Controller
  • WP_Test_REST_Tags_Controller

and brings consistency with:

  • WP_Test_REST_Posts_Controller
  • WP_Test_REST_Users_Controller

These test classes were previously updated to improve performance by creating less fixtures and reusing them where possible. While the pagination tests for categories and comments still passed due to enough items being created, the pagination test for tags did not work as expected and did not perform any assertions due to trying to iterate over an empty array of results.

This is now corrected by assigning the properties as intended and adding more assertions to the affected test.

Follow-up to [46657].

Props johnregan3, costdev, johnbillion.
See #54662.

Location:
trunk/tests/phpunit/tests/rest-api
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/rest-api/rest-categories-controller.php

    r52068 r53909  
    3939        // Set up categories for pagination tests.
    4040        for ( $i = 0; $i < self::$total_categories - 1; $i++ ) {
    41             $category_ids[] = $factory->category->create(
     41            self::$category_ids[] = $factory->category->create(
    4242                array(
    4343                    'name' => "Category {$i}",
  • trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

    r52389 r53909  
    118118        // Set up comments for pagination tests.
    119119        for ( $i = 0; $i < self::$total_comments - 1; $i++ ) {
    120             $comment_ids[] = $factory->comment->create(
     120            self::$comment_ids[] = $factory->comment->create(
    121121                array(
    122122                    'comment_content' => "Comment {$i}",
  • trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php

    r52068 r53909  
    5555        // Set up tags for pagination tests.
    5656        for ( $i = 0; $i < self::$total_tags; $i++ ) {
    57             $tag_ids[] = $factory->tag->create(
     57            self::$tag_ids[] = $factory->tag->create(
    5858                array(
    5959                    'name' => "Tag {$i}",
     
    413413        $tags     = $response->get_data();
    414414
     415        $this->assertNotEmpty( $tags );
     416
    415417        $i = 0;
    416418        foreach ( $tags as $tag ) {
     
    426428        $response = rest_get_server()->dispatch( $request );
    427429        $tags     = $response->get_data();
     430
     431        $this->assertNotEmpty( $tags );
    428432
    429433        foreach ( $tags as $tag ) {
Note: See TracChangeset for help on using the changeset viewer.