Make WordPress Core


Ignore:
Timestamp:
08/19/2022 04:13:38 PM (20 months ago)
Author:
SergeyBiryukov
Message:

Tests: Assign created fixtures to the dedicated class properties in some test classes.

This affects:

  • WP_Test_REST_Categories_Controller
  • WP_Test_REST_Comments_Controller
  • WP_Test_REST_Tags_Controller

and brings consistency with:

  • WP_Test_REST_Posts_Controller
  • WP_Test_REST_Users_Controller

These test classes were previously updated to improve performance by creating less fixtures and reusing them where possible. While the pagination tests for categories and comments still passed due to enough items being created, the pagination test for tags did not work as expected and did not perform any assertions due to trying to iterate over an empty array of results.

This is now corrected by assigning the properties as intended and adding more assertions to the affected test.

Follow-up to [46657].

Props johnregan3, costdev, johnbillion.
See #54662.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

    r52389 r53909  
    118118        // Set up comments for pagination tests.
    119119        for ( $i = 0; $i < self::$total_comments - 1; $i++ ) {
    120             $comment_ids[] = $factory->comment->create(
     120            self::$comment_ids[] = $factory->comment->create(
    121121                array(
    122122                    'comment_content' => "Comment {$i}",
Note: See TracChangeset for help on using the changeset viewer.