Changeset 53911

Timestamp:

08/19/2022 08:58:34 PM (4 years ago)

Author:

joedolson

Message:

Permalinks: Fix aria-live text when removing custom structure.

Change the notification announced when a custom structure is removed. Previously, the notification incorrectly indicated that the structure was added for both actions. This changes the notification to correctly announce removals when structures are removed.

Props joedolson, kebbet, SergeyBiryukov.
Fixes #56230.

Location:

trunk/src

Files:

• js/_enqueues/admin/common.js (modified) (1 diff)
• wp-admin/options-permalink.php (modified) (2 diffs)

trunk/src/js/_enqueues/admin/common.js

@@ -752 +752 @@
             selectionEnd            = $permalinkStructure[ 0 ].selectionEnd,
             textToAppend            = $( this ).text().trim(),
-            textToAnnounce          = $( this ).attr( 'data-added' ),
+            textToAnnounce,
             newSelectionStart;
+
+        if ( $( this ).hasClass( 'active' ) ) {
+                textToAnnounce = $( this ).attr( 'data-removed' );
+        } else {
+                textToAnnounce = $( this ).attr( 'data-added' );
+        }
 
         // Remove structure tag if already part of the structure.

trunk/src/wp-admin/options-permalink.php

@@ -310 +310 @@
 /* translators: %s: Permalink structure tag. */
 $tag_added = __( '%s added to permalink structure' );
-
+/* translators: %s: Permalink structure tag. */
+$tag_removed = __( '%s removed from permalink structure' );
 /* translators: %s: Permalink structure tag. */
 $tag_already_used = __( '%s (already used in permalink structure)' );
@@ -379 +380 @@
                                                                                 aria-label="<?php echo esc_attr( sprintf( $explanation, $tag ) ); ?>"
                                                                                 data-added="<?php echo esc_attr( sprintf( $tag_added, $tag ) ); ?>"
+                                                                                data-removed="<?php echo esc_attr( sprintf( $tag_removed, $tag ) ); ?>"
                                                                                 data-used="<?php echo esc_attr( sprintf( $tag_already_used, $tag ) ); ?>">
                                                                                 <?php echo '%' . $tag . '%'; ?>