Changeset 53913 for trunk/src/wp-admin/edit-tag-form.php

Timestamp:

08/19/2022 11:04:04 PM (2 years ago)

Author:

joedolson

Message:

Taxonomy: Associate field descriptions with fields.

Use aria-describedby to associate the field descriptions and instructions with the form fields when creating or editing taxonomy terms.

Props afercia.
Fixes #55651.

File:

• trunk/src/wp-admin/edit-tag-form.php (modified) (5 diffs)

trunk/src/wp-admin/edit-tag-form.php

@@ -146 +146 @@
         <tr class="form-field form-required term-name-wrap">
             <th scope="row"><label for="name"><?php _ex( 'Name', 'term name' ); ?></label></th>
-            <td><input name="name" id="name" type="text" value="<?php echo $tag_name_value; ?>" size="40" aria-required="true" />
-            <p class="description"><?php echo $tax->labels->name_field_description; ?></p></td>
+            <td><input name="name" id="name" type="text" value="<?php echo $tag_name_value; ?>" size="40" aria-required="true" aria-describedby="name-description" />
+            <p class="description" id="name-description"><?php echo $tax->labels->name_field_description; ?></p></td>
         </tr>
 <?php if ( ! global_terms_enabled() ) { ?>
@@ -168 +168 @@
             $slug = isset( $tag->slug ) ? apply_filters( 'editable_slug', $tag->slug, $tag ) : '';
             ?>
-            <td><input name="slug" id="slug" type="text" value="<?php echo esc_attr( $slug ); ?>" size="40" />
-            <p class="description"><?php echo $tax->labels->slug_field_description; ?></p></td>
+            <td><input name="slug" id="slug" type="text" value="<?php echo esc_attr( $slug ); ?>" size="40" aria-describedby="slug-description" />
+            <p class="description" id="slug-description"><?php echo $tax->labels->slug_field_description; ?></p></td>
         </tr>
 <?php } ?>
@@ -187 +187 @@
                     'hierarchical'     => true,
                     'show_option_none' => __( 'None' ),
+                    'aria_describedby' => 'parent-description',
                 );
 
@@ -194 +195 @@
                 ?>
                 <?php if ( 'category' === $taxonomy ) : ?>
-                    <p class="description"><?php _e( 'Categories, unlike tags, can have a hierarchy. You might have a Jazz category, and under that have children categories for Bebop and Big Band. Totally optional.' ); ?></p>
+                    <p class="description" id="parent-description"><?php _e( 'Categories, unlike tags, can have a hierarchy. You might have a Jazz category, and under that have children categories for Bebop and Big Band. Totally optional.' ); ?></p>
                 <?php else : ?>
-                    <p class="description"><?php echo $tax->labels->parent_field_description; ?></p>
+                    <p class="description" id="parent-description"><?php echo $tax->labels->parent_field_description; ?></p>
                 <?php endif; ?>
             </td>
@@ -203 +204 @@
         <tr class="form-field term-description-wrap">
             <th scope="row"><label for="description"><?php _e( 'Description' ); ?></label></th>
-            <td><textarea name="description" id="description" rows="5" cols="50" class="large-text"><?php echo $tag->description; // textarea_escaped ?></textarea>
-            <p class="description"><?php echo $tax->labels->desc_field_description; ?></p></td>
+            <td><textarea name="description" id="description" rows="5" cols="50" class="large-text" aria-describedby="description-description"><?php echo $tag->description; // textarea_escaped ?></textarea>
+            <p class="description" id="description-description"><?php echo $tax->labels->desc_field_description; ?></p></td>
         </tr>
         <?php