Changeset 53914 for trunk/src/wp-includes/option.php

Timestamp:

08/20/2022 12:25:13 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Check for deprecated options before wp_installing().

This is a micro-optimization that makes the conditional several times faster for non-deprecated options by avoiding an unnecessary function call.

Functions affected:

• get_option()
• update_option()
• add_option()

Follow-up to [48575].

See #55647.

File:

• trunk/src/wp-includes/option.php (modified) (3 diffs)

trunk/src/wp-includes/option.php

@@ -96 +96 @@
     );
 
-    if ( ! wp_installing() && isset( $deprecated_keys[ $option ] ) ) {
+    if ( isset( $deprecated_keys[ $option ] ) && ! wp_installing() ) {
         _deprecated_argument(
             __FUNCTION__,
@@ -402 +402 @@
     );
 
-    if ( ! wp_installing() && isset( $deprecated_keys[ $option ] ) ) {
+    if ( isset( $deprecated_keys[ $option ] ) && ! wp_installing() ) {
         _deprecated_argument(
             __FUNCTION__,
@@ -592 +592 @@
     );
 
-    if ( ! wp_installing() && isset( $deprecated_keys[ $option ] ) ) {
+    if ( isset( $deprecated_keys[ $option ] ) && ! wp_installing() ) {
         _deprecated_argument(
             __FUNCTION__,