Make WordPress Core


Ignore:
Timestamp:
08/21/2022 04:55:18 PM (21 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Remove dynamic properties in theme tests.

Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

In this particular group of test files, the test classes contain a set_up() method which sets a few dynamic (not explicitly declared) properties.

For those properties which were set using a function call or variable access, the property has been explicitly declared on the class now.

For those properties which were set using a constant scalar expression and for which the value is not changed by any of the tests, the property setting has been removed in favor of declaring a class constant.

Includes removing one unused dynamic property declaration: $this->queries in Test_Block_Supports_Layout, which appears to be a copy/paste from Tests_Theme_wpThemeJsonResolver.

Follow-up to [40/tests], [260/tests], [598/tests], [50960], [52675], [53085], [53557], [53558], [53850], [53851], [53852], [53853], [53854], [53856].

Props jrf.
See #56033.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php

    r52372 r53916  
    1313class Tests_Theme_wpThemeJsonResolver extends WP_UnitTestCase {
    1414
     15    /**
     16     * Theme root directory.
     17     *
     18     * @var string
     19     */
     20    private $theme_root;
     21
     22    /**
     23     * Original theme directory.
     24     *
     25     * @var string
     26     */
     27    private $orig_theme_dir;
     28
     29    /**
     30     * Queries.
     31     *
     32     * @var array
     33     */
     34    private $queries = array();
     35
    1536    public function set_up() {
    1637        parent::set_up();
Note: See TracChangeset for help on using the changeset viewer.