Make WordPress Core


Ignore:
Timestamp:
08/22/2022 10:42:59 PM (23 months ago)
Author:
SergeyBiryukov
Message:

Tests: Consistently skip tests for non-implemented methods in REST API test classes.

WordPress core test suite uses PHPUnit's beStrictAboutTestsThatDoNotTestAnything option set to true, which marks a test as risky when no assertions are performed.

REST API test classes have some empty tests for non-implemented methods because these test classes extend the abstract WP_Test_REST_Controller_Testcase class, which requires several methods to be implemented that don't necessarily make sense for all REST API routes.

Some of these empty tests were already marked as skipped, but not in a consistent manner. Since skipping these tests is intentional for the time being, this commit aims to bring some consistency and adjust them all to be more accurately reported as skipped instead of risky.

The skipping can be reconsidered in the future when the tests are either removed as unnecessary or updated to actually perform assertions related to their behavior.

Follow-up to [40534], [41176], [41228].

Props Mte90, tomepajk, johnbillion, zieladam, SergeyBiryukov.
See #40538, #41463, #55652.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/rest-api/wpRestUrlDetailsController.php

    r52311 r53921  
    10501050
    10511051    public function test_context_param() {
    1052         $this->markTestSkipped( 'Controller does not use context_param.' );
     1052        $this->markTestSkipped( 'Controller does not use get_context_param().' );
    10531053    }
    10541054
    10551055    public function test_get_item() {
    1056         $this->markTestSkipped( 'Controller does not have get_item route.' );
     1056        $this->markTestSkipped( 'Controller does not implement get_item().' );
    10571057    }
    10581058
    10591059    public function test_create_item() {
    1060         $this->markTestSkipped( 'Controller does not have create_item route.' );
     1060        $this->markTestSkipped( 'Controller does not implement create_item().' );
    10611061    }
    10621062
    10631063    public function test_update_item() {
    1064         $this->markTestSkipped( 'Controller does not have update_item route.' );
     1064        $this->markTestSkipped( 'Controller does not implement update_item().' );
    10651065    }
    10661066
    10671067    public function test_delete_item() {
    1068         $this->markTestSkipped( 'Controller does not have delete_item route.' );
     1068        $this->markTestSkipped( 'Controller does not implement delete_item().' );
    10691069    }
    10701070
    10711071    public function test_prepare_item() {
    1072         $this->markTestSkipped( 'Controller does not have prepare_item route.' );
     1072        $this->markTestSkipped( 'Controller does not implement prepare_item().' );
    10731073    }
    10741074
Note: See TracChangeset for help on using the changeset viewer.