Changeset 53934 for trunk/src/wp-includes/functions.php

Timestamp:

08/23/2022 07:57:17 PM (2 years ago)

Author:

antpb

Message:

Media: Account for Windows when normalizing file paths.
Previously, Windows paths in the path_is_absolute function resulted in incorrect URIs. This patch adjusts for forward slashes and adds tests for the get_attached_file function.
Props Whissi, SergeyBiryukov, desrosj, stevenlinx, birgire, davidbaumwald, costdev, peterwilsoncc, audrasjb, hellofromTonya, johnbillion.
Fixes #36308.

File:

• trunk/src/wp-includes/functions.php (modified) (2 diffs)

trunk/src/wp-includes/functions.php

@@ -2084 +2084 @@
  *
  * @since 2.5.0
+ * @since 6.1.0 Allows normalized Windows paths (forward slashes).
  *
  * @param string $path File path.
@@ -2111 +2112 @@
     // Windows allows absolute paths like this.
     if ( preg_match( '#^[a-zA-Z]:\\\\#', $path ) ) {
+        return true;
+    }
+
+    // Normalized Windows paths for local filesystem and network shares (forward slashes).
+    if ( preg_match( '#(^[a-zA-Z]+:/|^//[\w!@\#\$%\^\(\)\-\'{}\.~]{1,15})#', $path ) ) {
         return true;
     }