Changeset 53949

Timestamp:

08/28/2022 10:09:39 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Explicitly declare all properties in WP_Test_Stream.

Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

The WP_Test_Stream class is a stream wrapper for use in the tests and must comply with the PHP requirements for such stream wrappers.

In this case, the class did not declare the required public $context property, which led to deprecation notices about the property being dynamically created from the Tests_Image_Editor_Imagick::test_streams() and Tests_Image_Meta::test_stream() tests.

Reference: ​PHP Manual: streamWrapper: Properties.

Follow-up to [49230], [50771], [53557], [53558], [53850], [53851], [53852], [53853], [53854], [53856], [53916], [53935], [53936], [53937], [53938], [53942], [53945], [53948].

Props jrf, antonvlasenko.
See #56033.

File:

• trunk/tests/phpunit/includes/class-wp-test-stream.php (modified) (1 diff)

trunk/tests/phpunit/includes/class-wp-test-stream.php

@@ -30 +30 @@
     public $bucket;
     public $data_ref;
+
+    /**
+     * The current context.
+     *
+     * @link https://www.php.net/manual/en/class.streamwrapper.php
+     *
+     * @var resource|null
+     */
+    public $context;
 
     /**