Changeset 53950

Timestamp:

08/28/2022 07:15:37 PM (3 years ago)

Author:

Clorith

Message:

Site Health: Don't show issue groups unless there are items in them.

The Site Health Status screen groups issues into the categories good, recommended, and critical when displaying them to the end user.

Initially, this screen would show 0 critical issues while the checks were being performed, and then hide the group if no issues were discovered after all checks had completed, this not being an ideal user experience, as it is a better experience to show areas that have content, instead of hiding them after the fact.

This change makes the groups hidden by default, and also changes the logic to see if a group should be displayed when an item is added to the list (as opposed to the previous approach which only did this check once every single test had completed).

Props DavidAnderson, palmiak.
Fixes #47222.

Location:

trunk/src

Files:

• js/_enqueues/admin/site-health.js (modified) (2 diffs)
• wp-admin/site-health.php (modified) (3 diffs)

trunk/src/js/_enqueues/admin/site-health.js

@@ -169 +169 @@
         }
 
+        if ( 0 < parseInt( SiteHealth.site_status.issues.critical, 0 ) ) {
+            $( '#health-check-issues-critical' ).removeClass( 'hidden' );
+        }
+        if ( 0 < parseInt( SiteHealth.site_status.issues.recommended, 0 ) ) {
+            $( '#health-check-issues-recommended' ).removeClass( 'hidden' );
+        }
+
         $( '.issues', '#health-check-issues-' + issue.status ).append( template( issue ) );
     }
@@ -211 +218 @@
         $circle.css( { strokeDashoffset: pct } );
 
-        if ( 1 > parseInt( SiteHealth.site_status.issues.critical, 0 ) ) {
-            $( '#health-check-issues-critical' ).addClass( 'hidden' );
-        }
-
-        if ( 1 > parseInt( SiteHealth.site_status.issues.recommended, 0 ) ) {
-            $( '#health-check-issues-recommended' ).addClass( 'hidden' );
-        }
-
         if ( 80 <= val && 0 === parseInt( SiteHealth.site_status.issues.critical, 0 ) ) {
             $wrapper.addClass( 'green' ).removeClass( 'orange' );

trunk/src/wp-admin/site-health.php

@@ -234 +234 @@
         </h2>
 
-        <p><?php _e( 'The site health check shows critical information about your WordPress configuration and items that require your attention.' ); ?></p>
-
-        <div class="site-health-issues-wrapper" id="health-check-issues-critical">
+        <p><?php _e( 'The site health check shows information about your WordPress configuration and items that may need your attention.' ); ?></p>
+
+        <div class="site-health-issues-wrapper hidden" id="health-check-issues-critical">
             <h3 class="site-health-issue-count-title">
                 <?php
@@ -244 +244 @@
             </h3>
 
+            <p><?php _e( 'Critical issues are items that may have a high impact on your sites performance or security, and resolving these issues should be prioritized.' ); ?></p>
+
             <div id="health-check-site-status-critical" class="health-check-accordion issues"></div>
         </div>
 
-        <div class="site-health-issues-wrapper" id="health-check-issues-recommended">
+        <div class="site-health-issues-wrapper hidden" id="health-check-issues-recommended">
             <h3 class="site-health-issue-count-title">
                 <?php
@@ -254 +256 @@
                 ?>
             </h3>
+
+            <p><?php _e( 'Recommended items are considered beneficial to your site, although not as important to prioritize as a critical issue, they may include improvements to things such as; Performance, user experience, and more.' ); ?></p>
 
             <div id="health-check-site-status-recommended" class="health-check-accordion issues"></div>