Changeset 53984 for branches/3.9/src/wp-includes/post-template.php

Timestamp:

08/30/2022 03:54:51 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Grouped backports to the 3.9 branch.

• Posts, Post Types: Escape output within the_meta().
• General: Ensure bookmark query limits are numeric.
• Plugins: Escape output in error messages.

Merges [53958-53960] to the 3.9 branch.
Props tykoted, martinkrcho, xknown, dd32, peterwilsoncc, paulkevan, timothyblynjacobs.

Location:

branches/3.9

Files:

• . (modified) (1 prop)
• src/wp-includes/post-template.php (modified) (2 diffs)

branches/3.9/src/wp-includes/post-template.php

@@ -863 +863 @@
  * Display list of post custom fields.
  *
- * @internal This will probably change at some point...
  * @since 1.2.0
- * @uses apply_filters() Calls 'the_meta_key' on list item HTML content, with key and value as separate parameters.
+ *
+ * @deprecated 6.0.2 Use get_post_meta() to retrieve post meta and render manually.
  */
 function the_meta() {
+        _deprecated_function( __FUNCTION__, '6.0.2', 'get_post_meta()' );
         if ( $keys = get_post_custom_keys() ) {
                 echo "<ul class='post-meta'>\n";
@@ -886 +887 @@
                          * @param string $value Meta value.
                          */
-                        echo apply_filters( 'the_meta_key', "<li><span class='post-meta-key'>$key:</span> $value</li>\n", $key, $value );
+                        echo apply_filters( 'the_meta_key', "<li><span class='post-meta-key'>" . esc_html( $key ) . ":</span>" . esc_html( $value ) . "</li>\n", $key, $value );
                 }
                 echo "</ul>\n";