Changeset 54053

Timestamp:

09/01/2022 05:04:52 PM (3 years ago)

Author:

flixos90

Message:

Site Health: Refine persistent object cache check tests.

This changeset makes these tests more reliable by having them less affected by external environment factors, fixing occasional failures.

See #56040.

File:

• trunk/tests/phpunit/tests/site-health.php (modified) (2 diffs)

trunk/tests/phpunit/tests/site-health.php

@@ -363 +363 @@
      * @ticket 56040
      */
-    public function test_object_cache_default_thresholds() {
-        $wp_site_health = new WP_Site_Health();
+    public function test_object_cache_default_thresholds_non_multisite() {
+        $wp_site_health = new WP_Site_Health();
+
+        // Set thresholds so high they should never be exceeded.
+        add_filter(
+            'site_status_persistent_object_cache_thresholds',
+            function() {
+                return array(
+                    'alloptions_count' => PHP_INT_MAX,
+                    'alloptions_bytes' => PHP_INT_MAX,
+                    'comments_count'   => PHP_INT_MAX,
+                    'options_count'    => PHP_INT_MAX,
+                    'posts_count'      => PHP_INT_MAX,
+                    'terms_count'      => PHP_INT_MAX,
+                    'users_count'      => PHP_INT_MAX,
+                );
+            }
+        );
 
         $this->assertFalse(
@@ -388 +404 @@
     public function test_object_cache_thresholds_check_can_be_bypassed() {
         $wp_site_health = new WP_Site_Health();
+
         add_filter( 'site_status_should_suggest_persistent_object_cache', '__return_true' );
-
         $this->assertTrue(
+            $wp_site_health->should_suggest_persistent_object_cache()
+        );
+
+        add_filter( 'site_status_should_suggest_persistent_object_cache', '__return_false', 11 );
+        $this->assertFalse(
             $wp_site_health->should_suggest_persistent_object_cache()
         );