Changeset 54060

Timestamp:

09/02/2022 12:11:28 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Add @coversNothing tag for PHP polyfill tests in phpunit/tests/compat/.

The @covers tags for these tests were previously removed to avoid notices when generating the code coverage report on PHP versions where these functions are natively available and not user-defined:

"@covers ::array_key_first" is invalid
"@covers ::array_key_last" is invalid
"@covers ::hash_hmac" is invalid
"@covers ::is_countable" is invalid
"@covers ::is_iterable" is invalid
"@covers ::mb_strlen" is invalid
"@covers ::mb_substr" is invalid
"@covers ::str_contains" is invalid
"@covers ::str_ends_with" is invalid
"@covers ::str_starts_with" is invalid

Explicitly including a @coversNothing annotation in this case appears to be a more appropriate option than not including any annotation at all.

Follow-up to [51852], [52038], [52039], [52040], [54049].

See #39265, #55652.

Location:

trunk/tests/phpunit/tests/compat

Files:

• arrayKeyFirst.php (modified) (1 diff)
• arrayKeyLast.php (modified) (1 diff)
• isCountable.php (modified) (1 diff)
• isIterable.php (modified) (1 diff)
• strContains.php (modified) (1 diff)
• strEndsWith.php (modified) (1 diff)
• strStartsWith.php (modified) (1 diff)

trunk/tests/phpunit/tests/compat/arrayKeyFirst.php

@@ -3 +3 @@
 /**
  * @group compat
+ *
+ * @coversNothing
  */
 class Tests_Compat_arrayKeyFirst extends WP_UnitTestCase {

trunk/tests/phpunit/tests/compat/arrayKeyLast.php

@@ -3 +3 @@
 /**
  * @group compat
+ *
+ * @coversNothing
  */
 class Tests_Compat_ArrayKeyLast extends WP_UnitTestCase {

trunk/tests/phpunit/tests/compat/isCountable.php

@@ -3 +3 @@
 /**
  * @group compat
+ *
+ * @coversNothing
  */
 class Tests_Compat_isCountable extends WP_UnitTestCase {

trunk/tests/phpunit/tests/compat/isIterable.php

@@ -3 +3 @@
 /**
  * @group compat
+ *
+ * @coversNothing
  */
 class Tests_Compat_isIterable extends WP_UnitTestCase {

trunk/tests/phpunit/tests/compat/strContains.php

@@ -3 +3 @@
 /**
  * @group compat
+ *
+ * @coversNothing
  */
 class Tests_Compat_strContains extends WP_UnitTestCase {

trunk/tests/phpunit/tests/compat/strEndsWith.php

@@ -3 +3 @@
 /**
  * @group compat
+ *
+ * @coversNothing
  */
 class Tests_Compat_StrEndsWith extends WP_UnitTestCase {

trunk/tests/phpunit/tests/compat/strStartsWith.php

@@ -3 +3 @@
 /**
  * @group compat
+ *
+ * @coversNothing
  */
 class Tests_Compat_StrStartsWith extends WP_UnitTestCase {