Changeset 54068

Timestamp:

09/05/2022 02:31:05 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Consistently set the current user in the tests for retaining a sticky status.

This affects:

• test_user_without_publish_posts_cannot_affect_sticky()
• test_user_without_publish_posts_cannot_affect_sticky_with_edit_post()

In both tests, the user is now set after creating the post, not before. This aims to better match the intention of the tests, as they ensure that a sticky status is unaffected for a post that is edited by a user without the publish_posts capability, not necessarily created by that user.

Includes minor documentation updates for consistency.

Follow-up to [33096], [35183].

See #55652.

File:

• trunk/tests/phpunit/tests/post.php (modified) (3 diffs)

trunk/tests/phpunit/tests/post.php

@@ -315 +315 @@
 
     /**
-     * If a post is sticky and is updated by a user that does not have the publish_post capability,
-     * it should _stay_ sticky.
+     * If a sticky post is updated via `wp_update_post()` by a user
+     * without the `publish_posts` capability, it should stay sticky.
      *
      * @ticket 24153
      */
-    public function test_user_without_publish_cannot_affect_sticky() {
+    public function test_user_without_publish_posts_cannot_affect_sticky() {
+        // Create a sticky post.
+        $post = self::factory()->post->create_and_get(
+            array(
+                'post_title'   => 'Will be changed',
+                'post_content' => 'Will be changed',
+            )
+        );
+        stick_post( $post->ID );
+
+        // Sanity check.
+        $this->assertTrue( is_sticky( $post->ID ) );
+
         wp_set_current_user( self::$grammarian_id );
 
@@ -327 +339 @@
         $this->assertTrue( current_user_can( 'edit_others_posts' ) );
         $this->assertTrue( current_user_can( 'edit_published_posts' ) );
-
-        // Create a sticky post.
-        $post = self::factory()->post->create_and_get(
-            array(
-                'post_title'   => 'Will be changed',
-                'post_content' => 'Will be changed',
-            )
-        );
-        stick_post( $post->ID );
-
-        // Sanity check.
-        $this->assertTrue( is_sticky( $post->ID ) );
 
         // Edit the post.
@@ -353 +353 @@
 
     /**
-     * If the `edit_post()` method is invoked by a user without publish_posts permission,
-     * the sticky status of the post should not be changed.
+     * If a sticky post is updated via `edit_post()` by a user
+     * without the `publish_posts` capability, it should stay sticky.
      *
      * @ticket 24153
      */
-    public function test_user_without_publish_cannot_affect_sticky_with_edit_post() {
+    public function test_user_without_publish_posts_cannot_affect_sticky_with_edit_post() {
         // Create a sticky post.
         $post = self::factory()->post->create_and_get(