Changeset 54071 for trunk/src/wp-admin/includes/class-wp-media-list-table.php

Timestamp:

09/05/2022 05:17:21 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use more meaningful variable names for output in the admin.

This renames some variables for clarity, per the ​Naming Conventions:

Don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.

• $out is renamed to $output in various list table methods and admin functions.
• $sep is renamed to $separator in various list table methods and admin functions.

This affects:

• WP_Comments_List_Table::handle_row_actions()
• WP_List_Table::row_actions()
• WP_Media_List_Table::column_default()
• WP_MS_Sites_List_Table::site_states()
• WP_MS_Users_List_Table::column_blogs()
• WP_Terms_List_Table::column_name()
• _wp_dashboard_recent_comments_row()
• image_align_input_fields()
• image_size_input_fields()
• wp_doc_link_parse()
• _post_states()
• _media_states()

Follow-up to [8653], [8692], [8864], [8910], [8911], [8916], [9103], [9153], [10607], [15491], [17793], [32644], [54070].

Props mukesh27, costdev.
See #56448, #55647.

File:

• trunk/src/wp-admin/includes/class-wp-media-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -636 +636 @@
 
             if ( is_array( $terms ) ) {
-                $out = array();
+                $output = array();
+
                 foreach ( $terms as $t ) {
                     $posts_in_term_qv             = array();
@@ -642 +643 @@
                     $posts_in_term_qv['term']     = $t->slug;
 
-                    $out[] = sprintf(
+                    $output[] = sprintf(
                         '<a href="%s">%s</a>',
                         esc_url( add_query_arg( $posts_in_term_qv, 'upload.php' ) ),
@@ -648 +649 @@
                     );
                 }
-                echo implode( wp_get_list_item_separator(), $out );
+
+                echo implode( wp_get_list_item_separator(), $output );
             } else {
                 echo '<span aria-hidden="true">&#8212;</span><span class="screen-reader-text">' . get_taxonomy( $taxonomy )->labels->no_terms . '</span>';