Changeset 54071 for trunk/src/wp-admin/includes/media.php

Timestamp:

09/05/2022 05:17:21 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use more meaningful variable names for output in the admin.

This renames some variables for clarity, per the ​Naming Conventions:

Don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.

• $out is renamed to $output in various list table methods and admin functions.
• $sep is renamed to $separator in various list table methods and admin functions.

This affects:

• WP_Comments_List_Table::handle_row_actions()
• WP_List_Table::row_actions()
• WP_Media_List_Table::column_default()
• WP_MS_Sites_List_Table::site_states()
• WP_MS_Users_List_Table::column_blogs()
• WP_Terms_List_Table::column_name()
• _wp_dashboard_recent_comments_row()
• image_align_input_fields()
• image_size_input_fields()
• wp_doc_link_parse()
• _post_states()
• _media_states()

Follow-up to [8653], [8692], [8864], [8910], [8911], [8916], [9103], [9153], [10607], [15491], [17793], [32644], [54070].

Props mukesh27, costdev.
See #56448, #55647.

File:

• trunk/src/wp-admin/includes/media.php (modified) (4 diffs)

trunk/src/wp-admin/includes/media.php

@@ -1156 +1156 @@
     }
 
-    $out = array();
+    $output = array();
 
     foreach ( $alignments as $name => $label ) {
-        $name  = esc_attr( $name );
-        $out[] = "<input type='radio' name='attachments[{$post->ID}][align]' id='image-align-{$name}-{$post->ID}' value='$name'" .
+        $name     = esc_attr( $name );
+        $output[] = "<input type='radio' name='attachments[{$post->ID}][align]' id='image-align-{$name}-{$post->ID}' value='$name'" .
             ( $checked == $name ? " checked='checked'" : '' ) .
             " /><label for='image-align-{$name}-{$post->ID}' class='align image-align-{$name}-label'>$label</label>";
     }
 
-    return implode( "\n", $out );
+    return implode( "\n", $output );
 }
 
@@ -1200 +1200 @@
     }
 
-    $out = array();
+    $output = array();
 
     foreach ( $size_names as $size => $label ) {
@@ -1236 +1236 @@
         $html .= '</div>';
 
-        $out[] = $html;
+        $output[] = $html;
     }
 
@@ -1242 +1242 @@
         'label' => __( 'Size' ),
         'input' => 'html',
-        'html'  => implode( "\n", $out ),
+        'html'  => implode( "\n", $output ),
     );
 }