Changeset 54076

Timestamp:

09/06/2022 12:11:20 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correct the tests for Site Health SQL versions matching readme.html.

These tests should check the initial $mysql_recommended_version and $mariadb_recommended_version properties, as WP_Site_Health::prepare_sql_data() redefines the former with the latter to simplify further processing if MariaDB is used, leading to a test failure:

Tests_Site_Health::test_mysql_recommended_version_matches_readme_html
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'5.7'
+'10.3'

This commit uses the initial property values to ensure the correct versions are being compared.

Follow-up to [54069].

See #55791.

File:

• trunk/tests/phpunit/tests/admin/wpSiteHealth.php (modified) (3 diffs)

trunk/tests/phpunit/tests/admin/wpSiteHealth.php

@@ -35 +35 @@
         /**
          * @ticket 55791
-         * @covers ::prepare_sql_data()
-         * @covers ::get_test_sql_server()
+         * @covers ::__construct()
          */
         public function test_mysql_recommended_version_matches_readme_html() {
@@ -42 +41 @@
                 $this->skipOnAutomatedBranches();
 
-                $this->instance->get_test_sql_server();
-
                 $reflection          = new ReflectionClass( $this->instance );
                 $reflection_property = $reflection->getProperty( 'mysql_recommended_version' );
@@ -57 +54 @@
         /**
          * @ticket 55791
-         * @covers ::prepare_sql_data()
-         * @covers ::get_test_sql_server()
+         * @covers ::__construct()
          */
         public function test_mariadb_recommended_version_matches_readme_html() {
                 // This test is designed to only run on trunk.
                 $this->skipOnAutomatedBranches();
-
-                $this->instance->get_test_sql_server();
 
                 $reflection          = new ReflectionClass( $this->instance );