Make WordPress Core


Ignore:
Timestamp:
09/06/2022 11:26:45 AM (22 months ago)
Author:
spacedmonkey
Message:

Networks and Sites: Use metadata api in *_network_options` functions.

Replace logic found in get_network_option, update_network_option and delete_network_option to use the metadata api. Using the metadata api has a number of benefits, such as consistency, default values and useful filters. This change also improves performance by priming the caches of all network options in a single database request.

Props spacedmonkey, swissspidy, sc0ttkclark, johnjamesjacoby, flixos90, jeremyfelt, pento, peterwilsoncc, mukesh27, desrosj.
Fixes #37181

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/option/multisite.php

    r53865 r54080  
    151151            $this->assertFalse( get_blog_option( $blog_id, $key2 ) );
    152152            // $this->assertFalse( get_option( $key2 ) );                        // Check get_option().
    153         }
    154 
    155         /**
    156          * @group multisite
    157          *
    158          * @covers ::get_site_option
    159          */
    160         public function test_site_notoptions() {
    161             $network_id     = get_current_network_id();
    162             $notoptions_key = "{$network_id}:notoptions";
    163 
    164             $_notoptions = wp_cache_get( 'notoptions', 'site-options' );
    165             $this->assertEmpty( $_notoptions );
    166             $_notoptions1 = wp_cache_get( $notoptions_key, 'site-options' );
    167             $this->assertEmpty( $_notoptions1 );
    168 
    169             get_site_option( 'burrito' );
    170 
    171             $notoptions = wp_cache_get( 'notoptions', 'site-options' );
    172             $this->assertEmpty( $notoptions );
    173             $notoptions1 = wp_cache_get( $notoptions_key, 'site-options' );
    174             $this->assertNotEmpty( $notoptions1 );
    175153        }
    176154
Note: See TracChangeset for help on using the changeset viewer.