Changeset 54083

Timestamp:

09/06/2022 02:41:08 PM (2 years ago)

Author:

SergeyBiryukov

Message:

REST API: Add the missing site_icon_url to the index.

The site_icon_url index was supposed to ship with WordPress 5.6, but was ​never backported to core.

This commit backports the original PR from Gutenberg repository:

• ​#42957: REST API: Add the missing 'site_icon_url' to the index

Follow-up to [52080].

Props Mamaduka, bernhard-reiter, TimothyBlynJacobs.
See #56467.

Location:

trunk

Files:

• src/wp-includes/rest-api/class-wp-rest-server.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-server.php (modified) (1 diff)
• tests/qunit/fixtures/wp-api-generated.js (modified) (1 diff)

trunk/src/wp-includes/rest-api/class-wp-rest-server.php

@@ -1309 +1309 @@
 
         $this->add_image_to_index( $response, $site_icon_id, 'site_icon' );
+
+        $response->data['site_icon_url'] = get_site_icon_url();
     }
 

trunk/tests/phpunit/tests/rest-api/rest-server.php

@@ -1085 +1085 @@
         $this->assertArrayHasKey( 'site_logo', $data );
         $this->assertArrayHasKey( 'site_icon', $data );
+        $this->assertArrayHasKey( 'site_icon_url', $data );
     }
 

trunk/tests/qunit/fixtures/wp-api-generated.js

@@ -10782 +10782 @@
     },
     "site_logo": 0,
-    "site_icon": 0
+    "site_icon": 0,
+    "site_icon_url": ""
 };