Changeset 54088 for trunk/tests/phpunit/tests/customize/manager.php

Timestamp:

09/06/2022 10:03:10 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correctly use the factory method.

This replaces all non-static calls to the WP_UnitTestCase_Base::factory() method with static function calls, since the method is declared as static.

This is a consistency improvement for the test suite.

Follow up to [35225], [35242], [49603], [54087].

Props jrf.
See #55652.

File:

• trunk/tests/phpunit/tests/customize/manager.php (modified) (15 diffs)

trunk/tests/phpunit/tests/customize/manager.php

@@ -163 +163 @@
     public function test_constructor_deferred_changeset_uuid() {
         wp_set_current_user( self::$admin_user_id );
-        $other_admin_user_id = $this->factory()->user->create( array( 'role' => 'admin' ) );
+        $other_admin_user_id = self::factory()->user->create( array( 'role' => 'admin' ) );
 
         $data = array(
@@ -172 +172 @@
 
         $uuid1 = wp_generate_uuid4();
-        $this->factory()->post->create(
+        self::factory()->post->create(
             array(
                 'post_type'     => 'customize_changeset',
@@ -188 +188 @@
          */
         $uuid2   = wp_generate_uuid4();
-        $post_id = $this->factory()->post->create(
+        $post_id = self::factory()->post->create(
             array(
                 'post_type'     => 'customize_changeset',
@@ -425 +425 @@
     public function test_find_changeset_post_id() {
         $uuid    = wp_generate_uuid4();
-        $post_id = $this->factory()->post->create(
+        $post_id = self::factory()->post->create(
             array(
                 'post_name'    => $uuid,
@@ -455 +455 @@
         $uuid         = wp_generate_uuid4();
         $wp_customize = new WP_Customize_Manager( array( 'changeset_uuid' => $uuid ) );
-        $post_id      = $this->factory()->post->create(
+        $post_id      = self::factory()->post->create(
             array(
                 'post_name'    => $uuid,
@@ -483 +483 @@
             'blogdescription' => array( 'value' => 'Greet the world' ),
         );
-        $this->factory()->post->create(
+        self::factory()->post->create(
             array(
                 'post_name'    => $uuid,
@@ -566 +566 @@
             )
         );
-        $existing_published_home_page_id   = $this->factory()->post->create(
+        $existing_published_home_page_id   = self::factory()->post->create(
             array(
                 'post_name'   => 'home',
@@ -573 +573 @@
             )
         );
-        $existing_auto_draft_about_page_id = $this->factory()->post->create(
+        $existing_auto_draft_about_page_id = self::factory()->post->create(
             array(
                 'post_name'   => 'about',
@@ -821 +821 @@
         wp_set_current_user( self::$admin_user_id );
 
-        $existing_published_home_page_id = $this->factory()->post->create(
+        $existing_published_home_page_id = self::factory()->post->create(
             array(
                 'post_name'   => 'home',
@@ -1879 +1879 @@
             array(
                 'autosave' => true,
-                'user_id'  => $this->factory()->user->create( array( 'role' => 'administrator' ) ),
+                'user_id'  => self::factory()->user->create( array( 'role' => 'administrator' ) ),
             )
         );
@@ -2032 +2032 @@
         $new_sidebar_1 = array_reverse( $new_sidebars_widgets['sidebar-1'] );
 
-        $post_id = $this->factory()->post->create(
+        $post_id = self::factory()->post->create(
             array(
                 'post_type'    => 'customize_changeset',
@@ -2336 +2336 @@
             ),
         );
-        $this->factory()->post->create(
+        self::factory()->post->create(
             array(
                 'post_type'    => 'customize_changeset',
@@ -2831 +2831 @@
         $this->assertFalse( $this->manager->has_published_pages() );
 
-        $this->factory()->post->create(
+        self::factory()->post->create(
             array(
                 'post_type'   => 'page',
@@ -2839 +2839 @@
         $this->assertFalse( $this->manager->has_published_pages() );
 
-        $this->factory()->post->create(
+        self::factory()->post->create(
             array(
                 'post_type'   => 'page',
@@ -2865 +2865 @@
         $setting    = $this->manager->get_setting( $setting_id );
         $this->assertInstanceOf( 'WP_Customize_Filter_Setting', $setting );
-        $auto_draft_page = $this->factory()->post->create(
+        $auto_draft_page = self::factory()->post->create(
             array(
                 'post_type'   => 'page',