Changeset 54088 for trunk/tests/phpunit/tests/customize/nav-menus.php

Timestamp:

09/06/2022 10:03:10 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correctly use the factory method.

This replaces all non-static calls to the WP_UnitTestCase_Base::factory() method with static function calls, since the method is declared as static.

This is a consistency improvement for the test suite.

Follow up to [35225], [35242], [49603], [54087].

Props jrf.
See #55652.

File:

• trunk/tests/phpunit/tests/customize/nav-menus.php (modified) (6 diffs)

trunk/tests/phpunit/tests/customize/nav-menus.php

@@ -852 +852 @@
     public function test_sanitize_nav_menus_created_posts() {
         $menus                 = new WP_Customize_Nav_Menus( $this->wp_customize );
-        $contributor_user_id   = $this->factory()->user->create( array( 'role' => 'contributor' ) );
-        $author_user_id        = $this->factory()->user->create( array( 'role' => 'author' ) );
-        $administrator_user_id = $this->factory()->user->create( array( 'role' => 'administrator' ) );
-
-        $contributor_post_id   = $this->factory()->post->create(
+        $contributor_user_id   = self::factory()->user->create( array( 'role' => 'contributor' ) );
+        $author_user_id        = self::factory()->user->create( array( 'role' => 'author' ) );
+        $administrator_user_id = self::factory()->user->create( array( 'role' => 'administrator' ) );
+
+        $contributor_post_id   = self::factory()->post->create(
             array(
                 'post_status' => 'auto-draft',
@@ -864 +864 @@
             )
         );
-        $author_post_id        = $this->factory()->post->create(
+        $author_post_id        = self::factory()->post->create(
             array(
                 'post_status' => 'auto-draft',
@@ -872 +872 @@
             )
         );
-        $administrator_post_id = $this->factory()->post->create(
+        $administrator_post_id = self::factory()->post->create(
             array(
                 'post_status' => 'auto-draft',
@@ -881 +881 @@
         );
 
-        $draft_post_id = $this->factory()->post->create(
+        $draft_post_id = self::factory()->post->create(
             array(
                 'post_status' => 'draft',
@@ -889 +889 @@
         );
 
-        $private_post_id = $this->factory()->post->create(
+        $private_post_id = self::factory()->post->create(
             array(
                 'post_status' => 'private',
@@ -991 +991 @@
         $trashed_post_id = $r->ID;
 
-        $pre_published_post_id = $this->factory()->post->create( array( 'post_status' => 'publish' ) );
+        $pre_published_post_id = self::factory()->post->create( array( 'post_status' => 'publish' ) );
 
         $setting_id = 'nav_menus_created_posts';