Changeset 54088 for trunk/tests/phpunit/tests/oembed/WpEmbed.php

Timestamp:

09/06/2022 10:03:10 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correctly use the factory method.

This replaces all non-static calls to the WP_UnitTestCase_Base::factory() method with static function calls, since the method is declared as static.

This is a consistency improvement for the test suite.

Follow up to [35225], [35242], [49603], [54087].

Props jrf.
See #55652.

File:

• trunk/tests/phpunit/tests/oembed/WpEmbed.php (modified) (8 diffs)

trunk/tests/phpunit/tests/oembed/WpEmbed.php

@@ -29 +29 @@
 
     public function test_maybe_run_ajax_cache_should_return_nothing_if_there_is_no_message() {
-        $GLOBALS['post'] = $this->factory()->post->create_and_get(
+        $GLOBALS['post'] = self::factory()->post->create_and_get(
             array(
                 'post_title' => 'Hello World',
@@ -42 +42 @@
 
     public function test_maybe_run_ajax_cache_should_return_javascript() {
-        $GLOBALS['post'] = $this->factory()->post->create_and_get(
+        $GLOBALS['post'] = self::factory()->post->create_and_get(
             array(
                 'post_title' => 'Hello World',
@@ -135 +135 @@
 
     public function test_delete_oembed_caches() {
-        $post_id = $this->factory()->post->create();
+        $post_id = self::factory()->post->create();
 
         add_post_meta( $post_id, '_oembed_foo', 'bar' );
@@ -148 +148 @@
 
     public function test_cache_oembed_invalid_post_type() {
-        $post_id = $this->factory()->post->create( array( 'post_type' => 'nav_menu_item' ) );
+        $post_id = self::factory()->post->create( array( 'post_type' => 'nav_menu_item' ) );
 
         $this->wp_embed->cache_oembed( $post_id );
@@ -155 +155 @@
 
     public function test_cache_oembed_empty_content() {
-        $post_id = $this->factory()->post->create( array( 'post_content' => '' ) );
+        $post_id = self::factory()->post->create( array( 'post_content' => '' ) );
 
         $this->wp_embed->cache_oembed( $post_id );
@@ -168 +168 @@
         $cachekey_time = '_oembed_time_' . $key_suffix;
 
-        $post_id = $this->factory()->post->create( array( 'post_content' => 'https://example.com/' ) );
+        $post_id = self::factory()->post->create( array( 'post_content' => 'https://example.com/' ) );
 
         add_filter( 'pre_oembed_result', array( $this, '_pre_oembed_result_callback' ) );
@@ -182 +182 @@
         global $post;
 
-        $post       = $this->factory()->post->create_and_get();
+        $post       = self::factory()->post->create_and_get();
         $url        = 'https://example.com/';
         $expected   = '<b>Embedded content</b>';
@@ -209 +209 @@
         global $post;
 
-        $post          = $this->factory()->post->create_and_get();
+        $post          = self::factory()->post->create_and_get();
         $url           = 'https://example.com/';
         $expected      = '<a href="' . esc_url( $url ) . '">' . esc_html( $url ) . '</a>';